Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 808163002: Windows run-webkit-tests broke if --disable-breakpad was used (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add all members Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 version = 'win7' 69 version = 'win7'
70 else: 70 else:
71 version = host.platform.os_version 71 version = host.platform.os_version
72 port_name = port_name + '-' + version 72 port_name = port_name + '-' + version
73 return port_name 73 return port_name
74 74
75 def __init__(self, host, port_name, **kwargs): 75 def __init__(self, host, port_name, **kwargs):
76 super(WinPort, self).__init__(host, port_name, **kwargs) 76 super(WinPort, self).__init__(host, port_name, **kwargs)
77 self._version = port_name[port_name.index('win-') + len('win-'):] 77 self._version = port_name[port_name.index('win-') + len('win-'):]
78 assert self._version in self.SUPPORTED_VERSIONS, "%s is not in %s" % (se lf._version, self.SUPPORTED_VERSIONS) 78 assert self._version in self.SUPPORTED_VERSIONS, "%s is not in %s" % (se lf._version, self.SUPPORTED_VERSIONS)
79 if not self.get_option('disable_breakpad'): 79 if self.get_option('disable_breakpad'):
80 self._dump_reader = None
81 else:
80 self._dump_reader = DumpReaderWin(host, self._build_path()) 82 self._dump_reader = DumpReaderWin(host, self._build_path())
81 self._crash_service = None 83 self._crash_service = None
82 self._crash_service_available = None 84 self._crash_service_available = None
83 85
84 def additional_drt_flag(self): 86 def additional_drt_flag(self):
85 flags = super(WinPort, self).additional_drt_flag() 87 flags = super(WinPort, self).additional_drt_flag()
86 flags += ['--enable-direct-write'] 88 flags += ['--enable-direct-write']
87 if not self.get_option('disable_breakpad'): 89 if not self.get_option('disable_breakpad'):
88 flags += ['--enable-crash-reporter', '--crash-dumps-dir=%s' % self._ dump_reader.crash_dumps_directory()] 90 flags += ['--enable-crash-reporter', '--crash-dumps-dir=%s' % self._ dump_reader.crash_dumps_directory()]
89 return flags 91 return flags
90 92
91 def check_httpd(self): 93 def check_httpd(self):
92 res = super(WinPort, self).check_httpd() 94 res = super(WinPort, self).check_httpd()
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
237 return result 239 return result
238 240
239 def look_for_new_crash_logs(self, crashed_processes, start_time): 241 def look_for_new_crash_logs(self, crashed_processes, start_time):
240 if self.get_option('disable_breakpad'): 242 if self.get_option('disable_breakpad'):
241 return None 243 return None
242 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time) 244 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time)
243 245
244 def clobber_old_port_specific_results(self): 246 def clobber_old_port_specific_results(self):
245 if not self.get_option('disable_breakpad'): 247 if not self.get_option('disable_breakpad'):
246 self._dump_reader.clobber_old_results() 248 self._dump_reader.clobber_old_results()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698