Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 807743003: refactor optype to be computed once per refactoring request (Closed)

Created:
6 years ago by danrubel
Modified:
6 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

refactor optype to be computed once per refactoring request and hide optype computation internals BUG= R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=42412

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge and address comment #

Messages

Total messages: 5 (1 generated)
danrubel
6 years ago (2014-12-16 21:22:50 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/807743003/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart File pkg/analysis_server/lib/src/services/completion/optype.dart (right): https://codereview.chromium.org/807743003/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart#newcode49 pkg/analysis_server/lib/src/services/completion/optype.dart:49: OpType(); To prevent clients from accidentally using this ...
6 years ago (2014-12-16 21:33:02 UTC) #3
danrubel
https://codereview.chromium.org/807743003/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart File pkg/analysis_server/lib/src/services/completion/optype.dart (right): https://codereview.chromium.org/807743003/diff/1/pkg/analysis_server/lib/src/services/completion/optype.dart#newcode49 pkg/analysis_server/lib/src/services/completion/optype.dart:49: OpType(); On 2014/12/16 21:33:02, Paul Berry wrote: > To ...
6 years ago (2014-12-16 22:12:25 UTC) #4
danrubel
6 years ago (2014-12-16 22:15:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42412 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698