Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: pkg/analysis_server/test/services/completion/optype_test.dart

Issue 807743003: refactor optype to be computed once per refactoring request (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge and address comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/optype_test.dart
diff --git a/pkg/analysis_server/test/services/completion/optype_ast_visitor_test.dart b/pkg/analysis_server/test/services/completion/optype_test.dart
similarity index 98%
rename from pkg/analysis_server/test/services/completion/optype_ast_visitor_test.dart
rename to pkg/analysis_server/test/services/completion/optype_test.dart
index 6c1bc7750e1a4a16d6a0413ef23a1016ef9d89b3..3017031e72d082f93e2f8a921323361c34ff6cb1 100644
--- a/pkg/analysis_server/test/services/completion/optype_ast_visitor_test.dart
+++ b/pkg/analysis_server/test/services/completion/optype_test.dart
@@ -4,7 +4,7 @@
library test.services.completion.computer.dart.optype;
-import 'package:analysis_server/src/services/completion/optype_ast_visitor.dart';
+import 'package:analysis_server/src/services/completion/optype.dart';
import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -15,13 +15,13 @@ import '../../reflective_tests.dart';
main() {
groupSep = ' | ';
- runReflectiveTests(OpTypeAstVisitorTest);
+ runReflectiveTests(OpTypeTest);
}
@ReflectiveTestCase()
-class OpTypeAstVisitorTest {
+class OpTypeTest {
- OpTypeAstVisitor visitor;
+ OpType visitor;
void addTestSource(String content, {bool resolved: false}) {
int offset = content.indexOf('^');
@@ -38,8 +38,7 @@ class OpTypeAstVisitorTest {
context.resolveCompilationUnit2(source, source) :
context.parseCompilationUnit(source);
AstNode node = new NodeLocator.con1(offset).searchWithin(unit);
- visitor = new OpTypeAstVisitor(offset);
- node.accept(visitor);
+ visitor = new OpType.forCompletion(node, offset);
}
void assertOpType({bool invocation: false, bool returnValue: false,

Powered by Google App Engine
This is Rietveld 408576698