Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: Source/bindings/core/v8/DOMWrapperWorld.h

Issue 806693004: Use new phantom handles for ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Start using V8 phantom handles in Blink Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/DOMWrapperWorld.h
diff --git a/Source/bindings/core/v8/DOMWrapperWorld.h b/Source/bindings/core/v8/DOMWrapperWorld.h
index 7f1f8a6e1bff3fc7f7e120a2f7106e18f389bd77..12119d244e0523d44741a9ec2033b6b8966c5c76 100644
--- a/Source/bindings/core/v8/DOMWrapperWorld.h
+++ b/Source/bindings/core/v8/DOMWrapperWorld.h
@@ -137,9 +137,9 @@ private:
DOMWrapperWorld* world() const { return m_world; }
void setWorld(DOMWrapperWorld* world) { m_world = world; }
- void setWeak(void (*callback)(const v8::WeakCallbackData<v8::Value, DOMObjectHolderBase>&))
+ void setPhantom(void (*callback)(const v8::PhantomCallbackData<DOMObjectHolderBase>&))
{
- m_wrapper.setWeak(this, callback);
+ m_wrapper.setPhantom(this, callback);
}
private:
@@ -175,7 +175,7 @@ public:
private:
DOMWrapperWorld(v8::Isolate*, int worldId, int extensionGroup);
- static void weakCallbackForDOMObjectHolder(const v8::WeakCallbackData<v8::Value, DOMObjectHolderBase>&);
+ static void phantomCallbackForDOMObjectHolder(const v8::PhantomCallbackData<DOMObjectHolderBase>&);
void registerDOMObjectHolderInternal(PassOwnPtr<DOMObjectHolderBase>);
void unregisterDOMObjectHolder(DOMObjectHolderBase*);

Powered by Google App Engine
This is Rietveld 408576698