Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 806283003: [NaCl SDK] Always use cmd.exe for SHELL in Windows Makefiles (Closed)

Created:
6 years ago by binji
Modified:
6 years ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Always use cmd.exe for SHELL in Windows Makefiles If SHELL is not set then make will search PATH for sh.exe. If it is found, it will use that instead of cmd.exe. If the sh.exe exists in a path with a space, the command will fail to run. BUG=none R=sbc@chromium.org Committed: https://crrev.com/b8c39431fc3e8631a9fc252d1c794f86e80e1235 Cr-Commit-Position: refs/heads/master@{#309450}

Patch Set 1 #

Patch Set 2 : whoops, typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M native_client_sdk/src/resources/Makefile.index.template View 1 1 chunk +7 lines, -0 lines 0 comments Download
M native_client_sdk/src/tools/common.mk View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
6 years ago (2014-12-16 20:49:48 UTC) #1
Sam Clegg
lgtm
6 years ago (2014-12-16 20:55:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/806283003/20001
6 years ago (2014-12-22 19:29:13 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-22 20:11:40 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-22 20:12:37 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8c39431fc3e8631a9fc252d1c794f86e80e1235
Cr-Commit-Position: refs/heads/master@{#309450}

Powered by Google App Engine
This is Rietveld 408576698