Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: native_client_sdk/src/resources/Makefile.index.template

Issue 806283003: [NaCl SDK] Always use cmd.exe for SHELL in Windows Makefiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: whoops, typo Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | native_client_sdk/src/tools/common.mk » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/resources/Makefile.index.template
diff --git a/native_client_sdk/src/resources/Makefile.index.template b/native_client_sdk/src/resources/Makefile.index.template
index 2881fdfea30f4225a85ce23b13d77c4a1014d413..5b6db699228249820556e4c8f8f76852b918917a 100644
--- a/native_client_sdk/src/resources/Makefile.index.template
+++ b/native_client_sdk/src/resources/Makefile.index.template
@@ -7,6 +7,13 @@
#   http://www.gnu.org/software/make/manual/make.html
#
+# Always use cmd.exe as the shell on Windows. Otherwise Make may try to search
+# the path for sh.exe. If it is found in a path with a space, the command will
+# fail.
+ifeq ($(OS),Windows_NT)
+ SHELL := cmd.exe
+endif
+
PROJECTS := \
[[for project in projects:]]
{{project}} \
« no previous file with comments | « no previous file | native_client_sdk/src/tools/common.mk » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698