native_client_sdk/src/tools/common.mk - Issue 806283003: [NaCl SDK] Always use cmd.exe for SHELL in Windows Makefiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/tools/common.mk

Issue 806283003: [NaCl SDK] Always use cmd.exe for SHELL in Windows Makefiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: whoops, typo Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: native_client_sdk/src/tools/common.mk

diff --git a/native_client_sdk/src/tools/common.mk b/native_client_sdk/src/tools/common.mk

index a4e827ad05b00866549b00bc20f42624aa96bd5c..c2ed49452b1f355532f7e5ec9eb1e3bff8649552 100644

--- a/native_client_sdk/src/tools/common.mk

+++ b/native_client_sdk/src/tools/common.mk

@@ -142,7 +142,11 @@ endif

# Disable DOS PATH warning when using Cygwin based NaCl tools on Windows.

ifeq ($(OSNAME),win)

- CYGWIN?=nodosfilewarning

+ # Always use cmd.exe as the shell on Windows. Otherwise Make may try to

+ # search the path for sh.exe. If it is found in a path with a space, the

+ # command will fail.

+ SHELL := cmd.exe

+ CYGWIN ?= nodosfilewarning

export CYGWIN

endif

« no previous file with comments | « native_client_sdk/src/resources/Makefile.index.template ('k') | no next file » | no next file with comments »