sync/internal_api/test/test_entry_factory.cc - Issue 805633004: Enable Null Syncable ID which is different than Root ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/test/test_entry_factory.cc

Issue 805633004: Enable Null Syncable ID which is different than Root ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/test/test_entry_factory.cc

diff --git a/sync/internal_api/test/test_entry_factory.cc b/sync/internal_api/test/test_entry_factory.cc

index d2e6b73a33a2cba37ae3ced9660f1c93b68f55ed..8941040bf5d7d1b8f302f4bf14f42acff5cb75c4 100644

--- a/sync/internal_api/test/test_entry_factory.cc

+++ b/sync/internal_api/test/test_entry_factory.cc

@@ -76,7 +76,7 @@ int64 TestEntryFactory::CreateUnappliedNewItem(

entry.PutServerVersion(GetNextRevision());

entry.PutIsUnappliedUpdate(true);

entry.PutServerNonUniqueName(item_id);

- entry.PutServerParentId(syncable::GetNullId());

+ entry.PutServerParentId(syncable::Id::GetRoot());

entry.PutServerIsDir(is_unique);

entry.PutServerSpecifics(specifics);

if (is_unique) { // For top-level nodes.

« no previous file with comments | « sync/internal_api/sync_rollback_manager_base.cc ('k') | sync/internal_api/write_node.cc » ('j') | no next file with comments »