sync/internal_api/write_node.cc - Issue 805633004: Enable Null Syncable ID which is different than Root ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/write_node.cc

Issue 805633004: Enable Null Syncable ID which is different than Root ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/write_node.cc

diff --git a/sync/internal_api/write_node.cc b/sync/internal_api/write_node.cc

index b1f08725ac20d9eb8e98998d0622c557b17298a6..4aab598bc319be12c40ce307647f8e14bb4a23eb 100644

--- a/sync/internal_api/write_node.cc

+++ b/sync/internal_api/write_node.cc

@@ -461,7 +461,7 @@ bool WriteNode::SetPosition(const BaseNode& new_parent,

// Filter out redundant changes if both the parent and the predecessor match.

if (new_parent_id == entry_->GetParentId()) {

const syncable::Id& old = entry_->GetPredecessorId();

- if ((!predecessor && old.IsRoot()) ||

+ if ((!predecessor && old.IsNull()) ||

(predecessor && (old == predecessor->GetEntry()->GetId()))) {

return true;

}

« no previous file with comments | « sync/internal_api/test/test_entry_factory.cc ('k') | sync/syncable/directory.cc » ('j') | no next file with comments »