sync/internal_api/sync_rollback_manager_base.cc - Issue 805633004: Enable Null Syncable ID which is different than Root ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/sync_rollback_manager_base.cc

Issue 805633004: Enable Null Syncable ID which is different than Root ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/sync_rollback_manager_base.cc

diff --git a/sync/internal_api/sync_rollback_manager_base.cc b/sync/internal_api/sync_rollback_manager_base.cc

index baedec04dc9443740a2b80c5e851aa63803b092a..587ea56626fca787c837fda878cd560cf70b2908 100644

--- a/sync/internal_api/sync_rollback_manager_base.cc

+++ b/sync/internal_api/sync_rollback_manager_base.cc

@@ -270,7 +270,7 @@ bool SyncRollbackManagerBase::InitTypeRootNode(ModelType type) {

if (!entry.good())

return false;

- entry.PutParentId(syncable::Id());

+ entry.PutParentId(syncable::Id::GetRoot());

entry.PutBaseVersion(1);

entry.PutUniqueServerTag(ModelTypeToRootTag(type));

entry.PutNonUniqueName(ModelTypeToString(type));

« no previous file with comments | « sync/internal_api/sync_manager_impl_unittest.cc ('k') | sync/internal_api/test/test_entry_factory.cc » ('j') | no next file with comments »