Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 80513004: Revert 17963, 17962 and 17955: Random number generator in JS changes (Closed)

Created:
7 years, 1 month ago by danno
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Visibility:
Public.

Description

Revert 17963, 17962 and 17955: Random number generator in JS changes Revert 17966, 17965 also as collateral damage: Embed trigonometric lookup table. Due to Heapcheck and valgrind failures that are not yet fixed. TBR=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17981

Patch Set 1 #

Patch Set 2 : Remove Yang's changes, too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+816 lines, -339 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 3 chunks +11 lines, -66 lines 0 comments Download
M src/contexts.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/math.js View 1 6 chunks +113 lines, -78 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +42 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M src/serialize.cc View 1 chunk +4 lines, -0 lines 0 comments Download
D src/trig-table.h View 1 1 chunk +0 lines, -61 lines 0 comments Download
M src/v8.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/v8.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +60 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M test/cctest/test-weaktypedarrays.cc View 12 chunks +12 lines, -14 lines 0 comments Download
D tools/generate-trig-table.py View 1 1 chunk +0 lines, -84 lines 0 comments Download
M tools/gyp/v8.gyp View 1 3 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
Committed patchset #2 manually as r17981 (presubmit successful).
7 years, 1 month ago (2013-11-21 17:21:22 UTC) #1
Yang
On 2013/11/21 17:21:22, danno wrote: > Committed patchset #2 manually as r17981 (presubmit successful). lgtm.
7 years, 1 month ago (2013-11-21 17:22:00 UTC) #2
Yang
7 years, 1 month ago (2013-11-21 17:52:58 UTC) #3
Message was sent while issue was closed.
On 2013/11/21 17:22:00, Yang wrote:
> On 2013/11/21 17:21:22, danno wrote:
> > Committed patchset #2 manually as r17981 (presubmit successful).
> 
> lgtm.

I confirmed that r17963 exhibits leaks. To reproduce:

export GCC="g++"
export GYP_GENERATORS='ninja'
export BUILDTYPE=Debug
export GYP_DEFINES="linux_use_tcmalloc=1 linux_use_heapchecker=1
linux_keep_shadow_stacks=1 werror= component=shared_library target_arch=x64"
./build/gyp_chromium
ninja -C out/Debug chrome content_shell dump_syms minidump_stackwalk unit_tests
-j2000
tools/heapcheck/chrome_tests.sh -t unit --gtest_filter=EventUnittest.*

Powered by Google App Engine
This is Rietveld 408576698