DevTools: Show asynchronous call stacks on frontend.

DevTools: Show asynchronous call stacks on frontend.

This depends on https://codereview.chromium.org/74063002/

BUG=272416
R=pfeldman@chromium.org, yurys@chromium.org, caseq@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163361

[aandrey, 2013-11-21 17:44:36]

Known issue:
- Fails to evaluate on an async call frame (obviously).

Probably we should emulate the scope chain of an async call frame and run
evaluation under a corresponding "with" scope.

Other than that, the scope chain for an async call is a snapshot made at the
time in the past, with the exception of "global" and "with" scopes.

[aandrey, 2013-12-06 11:06:03]

PTAL.

How to turn on async stacks:
- checkbox in the settings page
- context menu option on CallStackSidebarPane while paused

[yurys, 2013-12-06 12:36:54]

lgtm

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
File Source/devtools/front_end/CallStackSidebarPane.js (right):

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/CallStackSidebarPane.js:92: * @param
{?WebInspector.CallStackSidebarPane.Placard} placard
Isn't placart === null <==> placard._callFrame.isAsync() ? I mean that you could
always bind _placardContextMenu to actual placard and check for
placard._callFrame.isAsync().

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
File Source/devtools/front_end/DebuggerModel.js (right):

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/DebuggerModel.js:825: if (script)
Why do we hide such frames?

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/DebuggerModel.js:1028: get callFrames()
style: please use functions.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
File Source/devtools/front_end/Placard.js (right):

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/Placard.js:89: get group()
style nit: we've decided to avoid getters/setters in the new code in favor of
methods, so please use methods when possible.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/Placard.js:146: get title()
ditto.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/Placard.js:172: for (var i = 0, placard; placard =
this.placards[i]; ++i) {
style: i < this.placards.length, we don't use this tyle of iteration in the
front-end code.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/Placard.js:179: for (var i = 0, placard; placard =
this.placards[i]; ++i) {
ditto.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/Placard.js:190: for (var i = 0, placard; placard =
this.placards[i]; ++i) {
ditto

[aandrey, 2013-12-06 16:09:24]

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
File Source/devtools/front_end/CallStackSidebarPane.js (right):

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/CallStackSidebarPane.js:92: * @param
{?WebInspector.CallStackSidebarPane.Placard} placard
On 2013/12/06 12:36:54, yurys wrote:
> Isn't placart === null <==> placard._callFrame.isAsync() ? I mean that you
could
> always bind _placardContextMenu to actual placard and check for
> placard._callFrame.isAsync().

Done.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
File Source/devtools/front_end/DebuggerModel.js (right):

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/DebuggerModel.js:825: if (script)
On 2013/12/06 12:36:54, yurys wrote:
> Why do we hide such frames?

Not sure. This is how it was before, I didn't change this behavior.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/DebuggerModel.js:1028: get callFrames()
On 2013/12/06 12:36:54, yurys wrote:
> style: please use functions.

renamed _callFrames -> callFrames

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
File Source/devtools/front_end/Placard.js (right):

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/Placard.js:89: get group()
On 2013/12/06 12:36:54, yurys wrote:
> style nit: we've decided to avoid getters/setters in the new code in favor of
> methods, so please use methods when possible.

Done.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/Placard.js:146: get title()
On 2013/12/06 12:36:54, yurys wrote:
> ditto.

Done.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/Placard.js:172: for (var i = 0, placard; placard =
this.placards[i]; ++i) {
On 2013/12/06 12:36:54, yurys wrote:
> style: i < this.placards.length, we don't use this tyle of iteration in the
> front-end code.

Done.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/Placard.js:179: for (var i = 0, placard; placard =
this.placards[i]; ++i) {
On 2013/12/06 12:36:54, yurys wrote:
> ditto.

Done.

https://codereview.chromium.org/80383004/diff/50001/Source/devtools/front_end...
Source/devtools/front_end/Placard.js:190: for (var i = 0, placard; placard =
this.placards[i]; ++i) {
On 2013/12/06 12:36:54, yurys wrote:
> ditto

Done.

[commit-bot: I haz the power, 2013-12-06 16:14:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/80383004/70001

[commit-bot: I haz the power, 2013-12-06 17:16:14]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-12-06 18:23:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aandrey@chromium.org/80383004/70001

[commit-bot: I haz the power, 2013-12-06 19:52:18]

Change committed as 163361