Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: Source/devtools/front_end/SettingsScreen.js

Issue 80383004: DevTools: Show asynchronous call stacks on frontend. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/Settings.js ('k') | Source/devtools/front_end/SourcesPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/SettingsScreen.js
diff --git a/Source/devtools/front_end/SettingsScreen.js b/Source/devtools/front_end/SettingsScreen.js
index 1ba521189203f5ae401ccb0d41712629d25a5968..f6313def8f61d51f4bac45f9161d7e88d3341614 100644
--- a/Source/devtools/front_end/SettingsScreen.js
+++ b/Source/devtools/front_end/SettingsScreen.js
@@ -83,7 +83,7 @@ WebInspector.SettingsScreen.regexValidator = function(text)
*/
WebInspector.SettingsScreen.integerValidator = function(min, max, text)
{
- var value = parseInt(text, 10);
+ var value = Number(text);
if (isNaN(value))
return "Invalid number format";
if (value < min || value > max)
@@ -395,6 +395,8 @@ WebInspector.GenericSettingsTab = function()
WebInspector.settings.skipStackFramesSwitch.addChangeListener(this._skipStackFramesSwitchOrPatternChanged, this);
WebInspector.settings.skipStackFramesPattern.addChangeListener(this._skipStackFramesSwitchOrPatternChanged, this);
+ p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UIString("Enable async stack traces"), WebInspector.settings.enableAsyncStackTraces));
+
p = this._appendSection(WebInspector.UIString("Profiler"));
p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UIString("Show advanced heap snapshot properties"), WebInspector.settings.showAdvancedHeapSnapshotProperties));
p.appendChild(WebInspector.SettingsTab.createSettingCheckbox(WebInspector.UIString("High resolution CPU profiling"), WebInspector.settings.highResolutionCpuProfiling));
« no previous file with comments | « Source/devtools/front_end/Settings.js ('k') | Source/devtools/front_end/SourcesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698