Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 803813003: Make callers of CommandLine use it via the base:: namespace. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, posciak+watch_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, dgrogan, aandrey+blink_chromium.org, jdduke+watch_chromium.org, miu+watch_chromium.org, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, vsevik, nona+watch_chromium.org, jam, jbauman+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, kalyank, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, penghuang+watch_chromium.org, timvolodine, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, nhiroki, mlamouri+watch-sensors_chromium.org, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jsbell+idb_chromium.org, jochen+watch_chromium.org, michaeln, riju_, serviceworker-reviews, avayvod+watch_chromium.org, mcasas+watch_chromium.org, yurys, kinuko+serviceworker, pfeldman, cmumford, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, danakj+watch_chromium.org, James Su, wjia+watch_chromium.org, kinuko+fileapi, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of CommandLine use it via the base:: namespace. Covers content/. BUG=422426 TEST=none TBR=ben@chromium.org Committed: https://crrev.com/83883c858834a2524223991537cc90e4be8f0468 Cr-Commit-Position: refs/heads/master@{#309496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -342 lines) Patch
M content/browser/appcache/appcache_url_request_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cross_site_transfer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_sensors/device_inertial_sensor_browsertest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/fileapi/browser_file_system_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_tree_node.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 8 chunks +17 lines, -13 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/loader/navigation_url_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/media_source_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_internals_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/webrtc_webcam_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_action_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_proxy.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/theme_helper_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/transition_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/transition_request_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/transition_request_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/opened_by_dom_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/npapi/plugin_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/site_isolation_policy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/site_isolation_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/appcache_interfaces.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/image_transport_surface.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_calayer_mac.mm View 1 chunk +10 lines, -10 lines 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/input_event_stream_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/set_process_title.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/gpu/gpu_main.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/plugin/plugin_channel.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/plugin/plugin_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_accelerated_surface_proxy_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_broker_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/public/browser/browser_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_base.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M content/public/test/content_browser_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_launcher.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/android/synchronous_compositor_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/browser_render_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools/devtools_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gin_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/media/video_track_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/ipc_network_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/host_globals.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M content/renderer/render_process_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 7 chunks +12 lines, -9 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 5 chunks +11 lines, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/resource_fetcher_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/savable_resources_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/scheduler/renderer_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/browsertests_apk/content_browser_tests_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/app/blink_test_platform_support_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/blink_test_platform_support_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/app/shell_crash_reporter_client.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M content/shell/app/shell_main_delegate_mac.mm View 3 chunks +5 lines, -5 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/shell/browser/shell.cc View 8 chunks +17 lines, -9 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 6 chunks +34 lines, -27 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/shell_net_log.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 4 chunks +12 lines, -9 lines 0 comments Download
M content/shell/common/shell_content_client.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/shell/common/webkit_test_helpers.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_process_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/renderer/shell_render_view_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/test_interfaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/tools/content_shell_crash_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/blink_test_environment.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/browser_side_navigation_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_browser_test_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_test_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_test_suite.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/webrtc_content_browsertest_base.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/zygote/zygote_linux.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803813003/1
6 years ago (2014-12-22 22:48:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 00:09:21 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-23 00:10:13 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/83883c858834a2524223991537cc90e4be8f0468
Cr-Commit-Position: refs/heads/master@{#309496}

Powered by Google App Engine
This is Rietveld 408576698