content/shell/browser/shell_net_log.cc - Issue 803813003: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_net_log.cc

Issue 803813003: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/shell_devtools_manager_delegate.cc ('k') | content/shell/browser/shell_url_request_context_getter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_net_log.cc

diff --git a/content/shell/browser/shell_net_log.cc b/content/shell/browser/shell_net_log.cc

index 9ba215fb59ce13b164697d17bb2e3e7e09434c5e..c006c2ff7b0dba6e731fe404c4d08ac4a457cd40 100644

--- a/content/shell/browser/shell_net_log.cc

+++ b/content/shell/browser/shell_net_log.cc

@@ -23,8 +23,9 @@ base::DictionaryValue* GetShellConstants(const std::string& app_name) {

base::DictionaryValue* dict = new base::DictionaryValue();

dict->SetString("name", app_name);

- dict->SetString("command_line",

- CommandLine::ForCurrentProcess()->GetCommandLineString());

+ dict->SetString(

+ "command_line",

+ base::CommandLine::ForCurrentProcess()->GetCommandLineString());

constants_dict->Set("clientInfo", dict);

@@ -34,7 +35,8 @@ base::DictionaryValue* GetShellConstants(const std::string& app_name) {

} // namespace

ShellNetLog::ShellNetLog(const std::string& app_name) {

- const CommandLine* command_line = CommandLine::ForCurrentProcess();

+ const base::CommandLine* command_line =

+ base::CommandLine::ForCurrentProcess();

if (command_line->HasSwitch(switches::kLogNetLog)) {

base::FilePath log_path =