Chromium Code Reviews
DescriptionRevert of Bind Window focus ability to the ExecutionContext instead of the process. (patchset #3 id:40001 of https://codereview.chromium.org/777483004/)
Reason for revert:
Crashing, see bug 441968
Original issue's description:
> Bind Window focus ability to the ExecutionContext instead of the process.
>
> WindowFocusAllowedIndicator is using a static variable that allows
> the entire process to focus a window. In addition, it is entirely
> stack based which prevents asynchronous methods to use it properly.
>
> By binding the window focus ability to the ExecutionContext,
> we can allow asynchronous methods but also, reduces the chances
> of unrelated scripts to focus windows when they should not be
> able to. Those two concerns are slightly related because an
> ExecutionContext will now be able to focus a window for a
> long period of time, thus, we do not want other ExecutionContext
> to be able to do that in the meantime.
>
> This is part of a three-sided CL:
> Part 1: <this>
> Part 2: https://codereview.chromium.org/786403003
> Part 3: https://codereview.chromium.org/722423004
>
> BUG=440740
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186849
TBR=jochen@chromium.org,mkwst@chromium.org,mlamouri@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=440740
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187209
Patch Set 1 #
Created: 6 years ago
(Patch set is too large to download)
Messages
Total messages: 9 (3 generated)
|