Remove WindowFocusAllowedIndicator and associated code.

Remove WindowFocusAllowedIndicator and associated code.

This is the last part of a three-sided CL:
Part 1: https://codereview.chromium.org/777483004/
Part 2: https://codereview.chromium.org/786403003/
Part 3: <this>

BUG=440740
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187135

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194297

[mlamouri (slow - plz ping), 2014-12-10 12:32:43]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[mlamouri (slow - plz ping), 2014-12-10 12:32:43]

Whoever reviews part 1 could have a look at this? :)

[jochen (gone - plz use gerrit), 2014-12-10 14:01:14]

lgtm

[mlamouri (slow - plz ping), 2014-12-10 14:13:38]

On 2014/12/10 14:01:14, jochen (slow) wrote:
> lgtm

Thanks for the quick review! :)

I was wondering actually if I should delete the default constructor and copy
constructors? It doesn't seem to be a common pattern in public/ interfaces but
I'm not sure why.

[Mike West, 2014-12-15 08:38:27]

On 2014/12/10 14:13:38, Mounir Lamouri wrote:
> On 2014/12/10 14:01:14, jochen (slow) wrote:
> > lgtm
> 
> Thanks for the quick review! :)
> 
> I was wondering actually if I should delete the default constructor and copy
> constructors? It doesn't seem to be a common pattern in public/ interfaces but
> I'm not sure why.

LGTM, sorry I was out most of last week. :/

If you're not using the default constructor or copy constructors, then yes,
delete them. I don't think there's any rule that you can't/shouldn't have them
however.

[mlamouri (slow - plz ping), 2014-12-15 10:30:43]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-12-15 10:31:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/722423004/1

[commit-bot: I haz the power, 2014-12-15 10:31:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-15 10:31:37]

Failed to apply patch for public/web/WebScopedWindowFocusAllowedIndicator.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file public/web/WebScopedWindowFocusAllowedIndicator.h
  Hunk #1 FAILED at 37.
  1 out of 1 hunk FAILED -- saving rejects to file
public/web/WebScopedWindowFocusAllowedIndicator.h.rej

Patch:       public/web/WebScopedWindowFocusAllowedIndicator.h
Index: public/web/WebScopedWindowFocusAllowedIndicator.h
diff --git a/public/web/WebScopedWindowFocusAllowedIndicator.h
b/public/web/WebScopedWindowFocusAllowedIndicator.h
index
aadfe1436c04588b46281b86f6dde03087577ba3..2a020b50233ce4bdcd4e94da2f5dd5748c10e491
100644
--- a/public/web/WebScopedWindowFocusAllowedIndicator.h
+++ b/public/web/WebScopedWindowFocusAllowedIndicator.h
@@ -37,20 +37,16 @@ namespace blink {
 
 class ScopedWindowFocusAllowedIndicator;
 class WebDocument;
-class WindowFocusAllowedIndicator;
 
 class WebScopedWindowFocusAllowedIndicator {
 public:
     explicit WebScopedWindowFocusAllowedIndicator(WebDocument* document) {
initialize(document); }
-    WebScopedWindowFocusAllowedIndicator() { initialize(); }
     ~WebScopedWindowFocusAllowedIndicator() { reset(); }
 
 private:
     BLINK_EXPORT void initialize(WebDocument*);
-    BLINK_EXPORT void initialize();
     BLINK_EXPORT void reset();
 
-    WebPrivateOwnPtr<WindowFocusAllowedIndicator> m_indicator;
     WebPrivateOwnPtr<ScopedWindowFocusAllowedIndicator> m_private;
 };

[mlamouri (slow - plz ping), 2014-12-15 10:51:39]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-12-15 10:52:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/722423004/20001

[commit-bot: I haz the power, 2014-12-15 12:00:09]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187135

[amineer_google, 2014-12-15 22:47:55]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/808563003/ by amineer@google.com.

The reason for reverting is: Crashing, see bug 441968.

[mlamouri (slow - plz ping), 2015-04-23 12:47:15]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-04-23 12:47:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/722423004/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2015-04-23 12:47:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/722423004/40001

[commit-bot: I haz the power, 2015-04-23 14:04:59]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194297