Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 786403003: Update extensions::MessagingBindings to use WebScopedWindowFocusAllowedIndicator with WebDocument. (Closed)

Created:
6 years ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
scheib
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, jochen (gone - plz use gerrit), Mike West
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update extensions::MessagingBindings to use WebScopedWindowFocusAllowedIndicator with WebDocument. This will allow Blink to delete some deprecated code. This is part of a three-sided CL: Part 1: https://codereview.chromium.org/777483004/ Part 2: <this> Part 3: https://codereview.chromium.org/722423004 BUG=440740 Committed: https://crrev.com/ebb4bf8090b06979fd44411af69304b505681f4d Cr-Commit-Position: refs/heads/master@{#307914} Committed: https://crrev.com/9b4c024f001519ea0c35decc04335bb768190ad5 Cr-Commit-Position: refs/heads/master@{#326007}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M extensions/renderer/messaging_bindings.cc View 1 4 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
mlamouri (slow - plz ping)
6 years ago (2014-12-10 12:24:50 UTC) #2
mlamouri (slow - plz ping)
+CC mkwst@ and jochen@ given that they are reviewers for parts 1 and 3.
6 years ago (2014-12-10 12:33:33 UTC) #3
scheib
lgtm
6 years ago (2014-12-10 20:39:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786403003/1
6 years ago (2014-12-11 16:04:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 16:55:37 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ebb4bf8090b06979fd44411af69304b505681f4d Cr-Commit-Position: refs/heads/master@{#307914}
6 years ago (2014-12-11 16:56:25 UTC) #8
Ken Rockot(use gerrit already)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/807593003/ by rockot@chromium.org. ...
6 years ago (2014-12-16 02:27:16 UTC) #9
scheib
Closing out of date patch, reopen if appropriate.
5 years, 9 months ago (2015-03-24 21:47:31 UTC) #10
mlamouri (slow - plz ping)
On 2015/03/24 at 21:47:31, scheib wrote: > Closing out of date patch, reopen if appropriate. ...
5 years, 9 months ago (2015-03-25 00:36:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786403003/20001
5 years, 8 months ago (2015-04-21 09:43:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 10:44:03 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 10:44:59 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b4c024f001519ea0c35decc04335bb768190ad5
Cr-Commit-Position: refs/heads/master@{#326007}

Powered by Google App Engine
This is Rietveld 408576698