replace COMPILE_ASSERT with static assert in wtf/

replace COMPILE_ASSERT with static assert in wtf/

BUG=442514
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187289

[Mostyn Bramley-Moore, 2014-12-16 00:43:47]

mostynb@opera.com changed reviewers:
+ thakis@chromium.org

[Mostyn Bramley-Moore, 2014-12-16 00:43:47]

@Nico: if https://codereview.chromium.org/805073002/ sticks, here's part of the
patch to remove usage of COMPILE_ASSERT completely.

[Nico, 2014-12-16 00:57:24]

lgtm

https://codereview.chromium.org/802203004/diff/1/Source/wtf/HashTable.h
File Source/wtf/HashTable.h (right):

https://codereview.chromium.org/802203004/diff/1/Source/wtf/HashTable.h#newco...
Source/wtf/HashTable.h:996: static_assert(!Traits::emptyValueIsZero ||
!IsPolymorphic<KeyType>::value, "EmptyValueCannotBeZeroForThingsWithAVtable");
At least for things where it's obvious how to do it (like here), should we also
use better descriptions? (here, we could add spaces between the words)

[Mostyn Bramley-Moore, 2014-12-16 10:30:39]

> At least for things where it's obvious how to do it (like here), should we
also
> use better descriptions? (here, we could add spaces between the words)

How does this look now?

[Nico, 2014-12-16 17:56:28]

still lgtm. All comments below optional.

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/ListHashSet.h
File Source/wtf/ListHashSet.h (right):

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/ListHashSet.h...
Source/wtf/ListHashSet.h:363: static_assert(sizeof(ListHashSetNode) ==
sizeof(ListHashSetNodeBase<ValueArg>), "Please add any fields to the base");
uber nit: I'd lower case the first character of the message, with the reasoning
that compiler diagnostics are all lower case too (except for if the first word
is a class name)

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/ListHashSet.h...
Source/wtf/ListHashSet.h:999: static_assert(HashTraits<T>::weakHandlingFlag ==
NoWeakHandlingInCollections, "ListHashSetDoesNotSupportWeakness");
intentionally no spaces here?

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/Vector.h
File Source/wtf/Vector.h (right):

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/Vector.h#newc...
Source/wtf/Vector.h:602: static_assert(!WTF::IsPolymorphic<T>::value ||
!VectorTraits<T>::canInitializeWithMemset, "Cant initialize with memset if there
is a vtable");
"cannot" maybe

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/dtoa/utils.h
File Source/wtf/dtoa/utils.h (right):

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/dtoa/utils.h#...
Source/wtf/dtoa/utils.h:291: static_assert(sizeof(Dest) == sizeof(Source),
"Verify sizes are equal");
"sizes should be equal" would be more similar to the other messages

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/text/TextCodec.h
File Source/wtf/text/TextCodec.h (right):

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/text/TextCode...
Source/wtf/text/TextCodec.h:69: static_assert(!DoNotFlush, "DoNotFlush is
falsy");
s/is/should be/?

[Mostyn Bramley-Moore, 2014-12-16 19:00:37]

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/ListHashSet.h
File Source/wtf/ListHashSet.h (right):

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/ListHashSet.h...
Source/wtf/ListHashSet.h:363: static_assert(sizeof(ListHashSetNode) ==
sizeof(ListHashSetNodeBase<ValueArg>), "Please add any fields to the base");
On 2014/12/16 17:56:28, Nico wrote:
> uber nit: I'd lower case the first character of the message, with the
reasoning
> that compiler diagnostics are all lower case too (except for if the first word
> is a class name)

Done.  Should we add this to the style guide?

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/ListHashSet.h...
Source/wtf/ListHashSet.h:999: static_assert(HashTraits<T>::weakHandlingFlag ==
NoWeakHandlingInCollections, "ListHashSetDoesNotSupportWeakness");
On 2014/12/16 17:56:28, Nico wrote:
> intentionally no spaces here?

Fixed.

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/Vector.h
File Source/wtf/Vector.h (right):

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/Vector.h#newc...
Source/wtf/Vector.h:602: static_assert(!WTF::IsPolymorphic<T>::value ||
!VectorTraits<T>::canInitializeWithMemset, "Cant initialize with memset if there
is a vtable");
On 2014/12/16 17:56:28, Nico wrote:
> "cannot" maybe

Done.

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/dtoa/utils.h
File Source/wtf/dtoa/utils.h (right):

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/dtoa/utils.h#...
Source/wtf/dtoa/utils.h:291: static_assert(sizeof(Dest) == sizeof(Source),
"Verify sizes are equal");
On 2014/12/16 17:56:28, Nico wrote:
> "sizes should be equal" would be more similar to the other messages

Done.

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/text/TextCodec.h
File Source/wtf/text/TextCodec.h (right):

https://codereview.chromium.org/802203004/diff/50001/Source/wtf/text/TextCode...
Source/wtf/text/TextCodec.h:69: static_assert(!DoNotFlush, "DoNotFlush is
falsy");
On 2014/12/16 17:56:28, Nico wrote:
> s/is/should be/?

Done.

[Mostyn Bramley-Moore, 2014-12-16 19:00:55]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-12-16 19:01:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/802203004/70001

[commit-bot: I haz the power, 2014-12-16 21:20:29]

Committed patchset #5 (id:70001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187289