Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: Source/wtf/OwnPtrCommon.h

Issue 802203004: replace COMPILE_ASSERT with static assert in wtf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: final fixups Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/wtf/OwnPtr.h ('k') | Source/wtf/PartitionAlloc.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Torch Mobile, Inc. 3 * Copyright (C) 2009 Torch Mobile, Inc.
4 * Copyright (C) 2010 Company 100 Inc. 4 * Copyright (C) 2010 Company 100 Inc.
5 * Copyright (C) 2013 Intel Corporation. All rights reserved. 5 * Copyright (C) 2013 Intel Corporation. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 29 matching lines...) Expand all
40 template<typename T> 40 template<typename T>
41 struct IsRefCounted { 41 struct IsRefCounted {
42 static const bool value = IsSubclass<T, RefCountedBase>::value 42 static const bool value = IsSubclass<T, RefCountedBase>::value
43 || IsSubclass<T, ThreadSafeRefCountedBase>::value; 43 || IsSubclass<T, ThreadSafeRefCountedBase>::value;
44 }; 44 };
45 45
46 template <typename T> 46 template <typename T>
47 struct OwnedPtrDeleter { 47 struct OwnedPtrDeleter {
48 static void deletePtr(T* ptr) 48 static void deletePtr(T* ptr)
49 { 49 {
50 COMPILE_ASSERT(!IsRefCounted<T>::value, UseRefPtrForRefCountedObjects); 50 static_assert(!IsRefCounted<T>::value, "use RefPtr for RefCounted object s");
51 COMPILE_ASSERT(sizeof(T) > 0, TypeMustBeComplete); 51 static_assert(sizeof(T) > 0, "type must be complete");
52 delete ptr; 52 delete ptr;
53 } 53 }
54 }; 54 };
55 55
56 template <typename T> 56 template <typename T>
57 struct OwnedPtrDeleter<T[]> { 57 struct OwnedPtrDeleter<T[]> {
58 static void deletePtr(T* ptr) 58 static void deletePtr(T* ptr)
59 { 59 {
60 COMPILE_ASSERT(!IsRefCounted<T>::value, UseRefPtrForRefCountedObjects); 60 static_assert(!IsRefCounted<T>::value, "use RefPtr for RefCounted object s");
61 COMPILE_ASSERT(sizeof(T) > 0, TypeMustBeComplete); 61 static_assert(sizeof(T) > 0, "type must be complete");
62 delete[] ptr; 62 delete[] ptr;
63 } 63 }
64 }; 64 };
65 65
66 template <class T, int n> 66 template <class T, int n>
67 struct OwnedPtrDeleter<T[n]> { 67 struct OwnedPtrDeleter<T[n]> {
68 COMPILE_ASSERT(sizeof(T) < 0, DoNotUseArrayWithSizeAsType); 68 static_assert(sizeof(T) < 0, "do not use array with size as type");
69 }; 69 };
70 70
71 } // namespace WTF 71 } // namespace WTF
72 72
73 #endif // WTF_OwnPtrCommon_h 73 #endif // WTF_OwnPtrCommon_h
OLDNEW
« no previous file with comments | « Source/wtf/OwnPtr.h ('k') | Source/wtf/PartitionAlloc.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698