replace COMPILE_ASSERT with static assert in wtf/

Source/wtf/ListHashSet.h

 /*
  * Copyright (C) 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, Benjamin Poulain <ikipou@gmail.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 342 matching lines @@
     public:
         typedef AllocatorArg NodeAllocator;
         typedef ValueArg Value;
 
         template <typename U>
         ListHashSetNode(U value)
             : ListHashSetNodeBase<ValueArg>(value) { }
 
         void* operator new(size_t, NodeAllocator* allocator)
         {
-            COMPILE_ASSERT(sizeof(ListHashSetNode) == sizeof(ListHashSetNodeBase<ValueArg>), PleaseAddAnyFieldsToTheBase);
+            static_assert(sizeof(ListHashSetNode) == sizeof(ListHashSetNodeBase<ValueArg>), "Please add any fields to the base");

[Nico, 2014/12/16 17:56:28]

uber nit: I'd lower case the first character of the message, with the reasoning
that compiler diagnostics are all lower case too (except for if the first word
is a class name)

[Mostyn Bramley-Moore, 2014/12/16 19:00:37]

Done.  Should we add this to the style guide?

             return allocator->allocateNode();
         }
 
         void setWasAlreadyDestructed()
         {
             if (NodeAllocator::isGarbageCollected && HashTraits<ValueArg>::needsDestruction)
                 this->m_prev = unlinkedNodePointer();
         }
 
         bool wasAlreadyDestructed() const
@@ skipping 314 matching lines @@
     {
         m_impl.swap(other.m_impl);
         std::swap(m_head, other.m_head);
         std::swap(m_tail, other.m_tail);
         this->m_allocatorProvider.swap(other.m_allocatorProvider);
     }
 
     template<typename T, size_t inlineCapacity, typename U, typename V>
     inline void ListHashSet<T, inlineCapacity, U, V>::finalize()
     {
-        COMPILE_ASSERT(!Allocator::isGarbageCollected, FinalizeOnHeapAllocatedListHashSetShouldNeverBeCalled);
+        static_assert(!Allocator::isGarbageCollected, "Heap allocated ListHashSet should never call finalize()");
         deleteAllNodes();
     }
 
     template<typename T, size_t inlineCapacity, typename U, typename V>
     inline T& ListHashSet<T, inlineCapacity, U, V>::first()
     {
         ASSERT(!isEmpty());
         return m_head->m_value;
     }
 
@@ skipping 280 matching lines @@
         if (!m_head)
             return;
 
         for (Node* node = m_head, *next = m_head->next(); node; node = next, next = node ? node->next() : 0)
             node->destroy(this->allocator());
     }
 
     template<typename T, size_t inlineCapacity, typename U, typename V>
     void ListHashSet<T, inlineCapacity, U, V>::trace(typename Allocator::Visitor* visitor)
     {
-        COMPILE_ASSERT(HashTraits<T>::weakHandlingFlag == NoWeakHandlingInCollections, ListHashSetDoesNotSupportWeakness);
+        static_assert(HashTraits<T>::weakHandlingFlag == NoWeakHandlingInCollections, "ListHashSetDoesNotSupportWeakness");

[Nico, 2014/12/16 17:56:28]

intentionally no spaces here?

[Mostyn Bramley-Moore, 2014/12/16 19:00:37]

Fixed.

         // This marks all the nodes and their contents live that can be
         // accessed through the HashTable. That includes m_head and m_tail
         // so we do not have to explicitly trace them here.
         m_impl.trace(visitor);
     }
 
 #if !ENABLE(OILPAN)
     template<typename T, size_t U, typename V>
     struct NeedsTracing<ListHashSet<T, U, V> > {
         static const bool value = false;
     };
 #endif
 
 } // namespace WTF
 
 using WTF::ListHashSet;
 
 #endif /* WTF_ListHashSet_h */