DescriptionChange ShowConfirmBubble() to take model by scoped_ptr.
It makes the ownership clear and it is a good pratice when transfering
ownership from caller to callee. Passing a scoped_ptr makes it harder to
misuse.
Discussion in chromium-dev mailing-list:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/9rTsfEI1Ux0/discussion
BUG=None
TEST=unit_tests --gtest_filter=ConfirmBubble*
R=pkasting@chromium.org,avi@chromium.org
Committed: https://crrev.com/f19a75afa37614c9e13af2b9a462d00377b9e57b
Cr-Commit-Position: refs/heads/master@{#308292}
Patch Set 1 #Messages
Total messages: 7 (1 generated)
|