Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 801043003: Change ShowConfirmBubble() to take model by scoped_ptr. (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ShowConfirmBubble() to take model by scoped_ptr. It makes the ownership clear and it is a good pratice when transfering ownership from caller to callee. Passing a scoped_ptr makes it harder to misuse. Discussion in chromium-dev mailing-list: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/9rTsfEI1Ux0/discussion BUG=None TEST=unit_tests --gtest_filter=ConfirmBubble* R=pkasting@chromium.org,avi@chromium.org Committed: https://crrev.com/f19a75afa37614c9e13af2b9a462d00377b9e57b Cr-Commit-Position: refs/heads/master@{#308292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/confirm_bubble.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/confirm_bubble_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/confirm_bubble_views.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/confirm_bubble_views_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
PTAL
6 years ago (2014-12-12 23:45:03 UTC) #1
Peter Kasting
LGTM
6 years ago (2014-12-12 23:47:23 UTC) #2
Avi (use Gerrit)
lgtm Yes! I like it.
6 years ago (2014-12-13 03:41:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801043003/1
6 years ago (2014-12-14 01:33:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-14 02:19:08 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-14 02:20:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f19a75afa37614c9e13af2b9a462d00377b9e57b
Cr-Commit-Position: refs/heads/master@{#308292}

Powered by Google App Engine
This is Rietveld 408576698