chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm - Issue 801043003: Change ShowConfirmBubble() to take model by scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm

Issue 801043003: Change ShowConfirmBubble() to take model by scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_menu_observer.cc ('k') | chrome/browser/ui/cocoa/confirm_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm b/chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm

index 3e057738e02f4d6095a0f6f1984469af0e2fa1ca..81bf1850c0d0f6118d1507a7ca2426ac36bc9423 100644

--- a/chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/confirm_bubble_cocoa.mm

@@ -47,14 +47,14 @@ namespace chrome {

void ShowConfirmBubble(gfx::NativeWindow window,

gfx::NativeView anchor_view,

const gfx::Point& origin,

- ConfirmBubbleModel* model) {

+ scoped_ptr<ConfirmBubbleModel> model) {

// Create a custom NSViewController that manages a bubble view, and add it to

// a child to the specified |anchor_view|. This controller will be

// automatically deleted when it loses first-responder status.

ConfirmBubbleController* controller =

[[ConfirmBubbleController alloc] initWithParent:anchor_view

origin:origin.ToCGPoint()

- model:model];

+ model:model.Pass()];

[anchor_view addSubview:[controller view]

positioned:NSWindowAbove

relativeTo:nil];