chrome/browser/ui/views/confirm_bubble_views_unittest.cc - Issue 801043003: Change ShowConfirmBubble() to take model by scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/confirm_bubble_views_unittest.cc

Issue 801043003: Change ShowConfirmBubble() to take model by scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/confirm_bubble_views_unittest.cc

diff --git a/chrome/browser/ui/views/confirm_bubble_views_unittest.cc b/chrome/browser/ui/views/confirm_bubble_views_unittest.cc

index 8135baa1627970d7f08dbd397216a261b61f0023..cba17e997d133f175eb9100926365fd3d2b96543 100644

--- a/chrome/browser/ui/views/confirm_bubble_views_unittest.cc

+++ b/chrome/browser/ui/views/confirm_bubble_views_unittest.cc

@@ -28,9 +28,9 @@ TEST_F(ConfirmBubbleViewsTest, CreateAndClose) {

// Bubble owns the model.

bool model_deleted = false;

- TestConfirmBubbleModel* model =

- new TestConfirmBubbleModel(&model_deleted, NULL, NULL, NULL);

- ConfirmBubbleViews* bubble = new ConfirmBubbleViews(model);

+ scoped_ptr<TestConfirmBubbleModel> model(

+ new TestConfirmBubbleModel(&model_deleted, NULL, NULL, NULL));

+ ConfirmBubbleViews* bubble = new ConfirmBubbleViews(model.Pass());

gfx::NativeWindow parent = parent_widget->GetNativeWindow();

constrained_window::CreateBrowserModalDialogViews(bubble, parent)->Show();

« no previous file with comments | « chrome/browser/ui/views/confirm_bubble_views.cc ('k') | no next file » | no next file with comments »