Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 800133008: Define SK_USE_FREETYPE_EMBOLDEN on Android (Closed)

Created:
5 years, 11 months ago by Xianzhu
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define SK_USE_FREETYPE_EMBOLDEN on Android (From https://codereview.chromium.org/411313002/ by h.joshi@samsung.com: Colored Emoji not drawn in Chrome if font style is set as Bold. When Bold font is asked, then Skia try to generate image/bitmap from path (if Bold font is not present) which is not correct case for Colored Emoji bitmap font.) Define SK_USE_FREETYPE_EMBOLDEN to prefer FreeType's emboldeing algorithm to Skia's. BUG=397069 R=h.joshi TBR=bungeman Committed: https://crrev.com/03c38d9dc88a9b1b040218fbdd56ed4e2eb82653 Cr-Commit-Position: refs/heads/master@{#310662}

Patch Set 1 #

Patch Set 2 : Correct comment #

Total comments: 2

Patch Set 3 : Combine with SK_BUILD_FOR_UNIX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M skia/config/SkUserConfig.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Xianzhu
5 years, 11 months ago (2015-01-05 19:09:19 UTC) #2
h.joshi
https://codereview.chromium.org/800133008/diff/20001/skia/config/SkUserConfig.h File skia/config/SkUserConfig.h (right): https://codereview.chromium.org/800133008/diff/20001/skia/config/SkUserConfig.h#newcode218 skia/config/SkUserConfig.h:218: #elif defined(SK_BUILD_FOR_ANDROID) Can we combine this with "SK_BUILD_FOR_UNIX"?
5 years, 11 months ago (2015-01-06 05:09:33 UTC) #4
Xianzhu
https://codereview.chromium.org/800133008/diff/20001/skia/config/SkUserConfig.h File skia/config/SkUserConfig.h (right): https://codereview.chromium.org/800133008/diff/20001/skia/config/SkUserConfig.h#newcode218 skia/config/SkUserConfig.h:218: #elif defined(SK_BUILD_FOR_ANDROID) On 2015/01/06 05:09:33, h.joshi wrote: > Can ...
5 years, 11 months ago (2015-01-06 17:21:12 UTC) #5
h.joshi
LGTM
5 years, 11 months ago (2015-01-06 18:13:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800133008/40001
5 years, 11 months ago (2015-01-08 22:04:12 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-09 01:51:59 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 01:54:48 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03c38d9dc88a9b1b040218fbdd56ed4e2eb82653
Cr-Commit-Position: refs/heads/master@{#310662}

Powered by Google App Engine
This is Rietveld 408576698