Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 411313002: Colored Emoji not drawn in Chrome if font style is set as Bold (Closed)

Created:
6 years, 5 months ago by h.joshi
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Colored Emoji not drawn in Chrome if font style is set as Bold. When Bold font is asked, then Skia try to generate image/bitmap from path (if Bold font is not present) which is not correct case for Colored Emoji bitmap font. BUG=397069

Patch Set 1 #

Patch Set 2 : Fixing typo error #

Total comments: 4

Patch Set 3 : Comment fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/core/SkScalerContext.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (2 generated)
h.joshi
Pls review.
6 years, 5 months ago (2014-07-24 15:15:33 UTC) #1
behdad_google
Looks right to me, though I'd default to enabled and only disable when needed. Skia ...
6 years, 5 months ago (2014-07-24 20:13:08 UTC) #2
h.joshi
@Behdad: Thank u for added Skia members. "fGenerateImageFromPath" is always true when we request for ...
6 years, 5 months ago (2014-07-25 10:48:40 UTC) #3
h.joshi
Pls review
6 years, 4 months ago (2014-07-27 17:20:36 UTC) #4
h.joshi
@reed/bungeman1: Pls review patch
6 years, 4 months ago (2014-07-29 13:14:22 UTC) #5
bungeman-skia
On 2014/07/29 13:14:22, h.joshi wrote: > @reed/bungeman1: Pls review patch This patch cannot be used ...
6 years, 4 months ago (2014-08-04 22:54:39 UTC) #6
h.joshi
@bungman1: SK_USE_FREETYPE_EMBOLDEN is already defined in "src/skia/config/SkUserConfig.h" file. Can you pls suggest what kind of ...
6 years, 4 months ago (2014-08-05 05:22:55 UTC) #7
bungeman-skia
On 2014/08/05 05:22:55, h.joshi wrote: > @bungman1: SK_USE_FREETYPE_EMBOLDEN is already defined in > "src/skia/config/SkUserConfig.h" > ...
6 years, 4 months ago (2014-08-05 21:16:57 UTC) #8
h.joshi
@bungeman1: Thank u for sharing this information, will debug more on the shared points. I ...
6 years, 4 months ago (2014-08-06 16:25:48 UTC) #9
bungeman-skia
On 2014/08/06 16:25:48, h.joshi wrote: > @bungeman1: Thank u for sharing this information, will debug ...
6 years, 4 months ago (2014-08-06 17:10:46 UTC) #10
h.joshi
@bungeman1: Going through code, to fix this issue we can either revert back to "eae" ...
6 years, 4 months ago (2014-08-13 12:59:16 UTC) #11
tomhudson
Per Ben's August 4th comment on https://code.google.com/p/chromium/issues/detail?id=397069, this bug should no longer occur with a ...
6 years, 4 months ago (2014-08-20 20:17:19 UTC) #12
h.joshi
My code base is little bit old and issue is reproducible in that, will update ...
6 years, 4 months ago (2014-08-21 14:59:44 UTC) #13
h.joshi
Getting some build error in sandbox linux, trying to find fix for the same. Once ...
6 years, 3 months ago (2014-08-26 15:53:01 UTC) #14
h.joshi
Some issue in my repo due to which issue was faced. I checked latest code ...
6 years, 3 months ago (2014-08-28 07:38:49 UTC) #15
h.joshi
Check in todays build as well and issue is reproducible. Using SK_USE_FREETYPE_EMBOLDEN will call FreeType ...
6 years, 3 months ago (2014-09-05 12:47:48 UTC) #16
reed1
https://codereview.chromium.org/411313002/diff/20001/src/core/SkScalerContext.h File src/core/SkScalerContext.h (right): https://codereview.chromium.org/411313002/diff/20001/src/core/SkScalerContext.h#newcode272 src/core/SkScalerContext.h:272: void updateImageFromPath(bool value) { fGenerateImageFromPath = value; } can ...
6 years, 3 months ago (2014-09-05 13:29:42 UTC) #18
h.joshi
@reed: Thank you for reviewing and sharing comments. Suggested changes are done, Please review. https://codereview.chromium.org/411313002/diff/20001/src/core/SkScalerContext.h ...
6 years, 3 months ago (2014-09-05 14:06:31 UTC) #19
h.joshi
@reed1: Made suggested changes Pls review
6 years, 3 months ago (2014-09-09 13:53:29 UTC) #20
h.joshi
@reed1: pls review this patch.
6 years, 3 months ago (2014-09-10 18:22:53 UTC) #21
reed1
ben is the skia-font expert, so deferring to him
6 years, 3 months ago (2014-09-10 18:32:15 UTC) #22
h.joshi
@ben: Please review this patch.
6 years, 3 months ago (2014-09-11 22:49:31 UTC) #23
h.joshi
@ben: Pls review this patch, it's more than a month old now.
6 years, 3 months ago (2014-09-16 02:47:56 UTC) #24
h.joshi
@ben: Pls review this patch, its been pending for 2 months now.
6 years, 3 months ago (2014-09-22 17:52:25 UTC) #25
h.joshi
Pls suggest for this patch, its pending for more than 2 month now.
6 years, 2 months ago (2014-10-09 02:50:18 UTC) #26
h.joshi
Issue is still reproducible in latest Chrome 41 developer build. Pls review this patch, if ...
6 years ago (2014-12-02 08:23:55 UTC) #27
h.joshi
5 years, 12 months ago (2014-12-24 06:53:26 UTC) #29
Issue is still reproducible and can also be seen in Google search also 
(google.co.kr) when rendered in complete CJK. Issue is also seen in other
Korean and Chinese sites as well, as most of the sites use "bold" for search
box.

Pls review and share comment.
In case we do not want to fix this issue now, pls suggest will close this patch.

Powered by Google App Engine
This is Rietveld 408576698