Issue 800053002: Revert of Fix crash when we don't have a plane to display

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 800053002: Revert of Fix crash when we don't have a plane to display (Closed)

Created:
6 years ago by Andre

Modified:
6 years ago

Reviewers:
dnicoara, achaulk

CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Fix crash when we don't have a plane to display (patchset #2 id:20001 of https://codereview.chromium.org/779173007/) Reason for revert: Broke Linux ChromiumOS Ozone. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/8423 GetPrimaryPlane was changed to return a pointer, but a callsite was not modified. Original issue's description: > Fix crash when we don't have a plane to display > > BUG=434115, 438835 > > Committed: https://crrev.com/208e6bf151685abc68ac836db5afb3543d8a1e92 > Cr-Commit-Position: refs/heads/master@{#308105} TBR=dnicoara@chromium.org,achaulk@chromium.org NOTREECHECKS=true NOTRY=true BUG=434115, 438835 Committed: https://crrev.com/4bd9bbd8d744053c2c671409cb8e2d485d337630 Cr-Commit-Position: refs/heads/master@{#308118}

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -12 lines)			Patch
M	ui/ozone/platform/dri/crtc_controller.cc	View	1 chunk	+4 lines, -8 lines	0 comments	Download
M	ui/ozone/platform/dri/overlay_plane.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/ozone/platform/dri/overlay_plane.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800053002/1

6 years ago (2014-12-12 17:48:40 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-12 17:51:03 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4bd9bbd8d744053c2c671409cb8e2d485d337630
Cr-Commit-Position: refs/heads/master@{#308118}