Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 779173007: Fix crash when we don't have a plane to display (Closed)

Created:
6 years ago by achaulk
Modified:
6 years ago
Reviewers:
dnicoara, Andre
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash when we don't have a plane to display BUG=434115, 438835 Committed: https://crrev.com/208e6bf151685abc68ac836db5afb3543d8a1e92 Cr-Commit-Position: refs/heads/master@{#308105}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M ui/ozone/platform/dri/crtc_controller.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/overlay_plane.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/overlay_plane.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
achaulk
This will fix the crash, but not the underlying issue of not getting a plane ...
6 years ago (2014-12-08 16:55:43 UTC) #2
dnicoara
lgtm Do you know why we're not getting a plane? I thought that there should ...
6 years ago (2014-12-08 17:00:20 UTC) #3
achaulk
On 2014/12/08 17:00:20, dnicoara wrote: > lgtm > > Do you know why we're not ...
6 years ago (2014-12-08 17:11:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/779173007/20001
6 years ago (2014-12-12 16:12:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 17:05:31 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/208e6bf151685abc68ac836db5afb3543d8a1e92 Cr-Commit-Position: refs/heads/master@{#308105}
6 years ago (2014-12-12 17:06:03 UTC) #8
Andre
Looks like this broke http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/8423
6 years ago (2014-12-12 17:34:50 UTC) #10
Andre
6 years ago (2014-12-12 17:48:25 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/800053002/ by andresantoso@chromium.org.

The reason for reverting is: Broke Linux ChromiumOS Ozone.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

GetPrimaryPlane was changed to return a pointer, but a callsite was
not modified.
.

Powered by Google App Engine
This is Rietveld 408576698