Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: Source/core/loader/DocumentWriter.cpp

Issue 799803004: Demistify DocumentParser::append (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: resurrect fixme Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/DOMPatchSupport.cpp ('k') | Source/core/xml/parser/XMLDocumentParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/DocumentWriter.cpp
diff --git a/Source/core/loader/DocumentWriter.cpp b/Source/core/loader/DocumentWriter.cpp
index a187c73339b49f2def4a33708229a953eef52453..311794929f64b1c59aebdb8d2cf424cea07bb312 100644
--- a/Source/core/loader/DocumentWriter.cpp
+++ b/Source/core/loader/DocumentWriter.cpp
@@ -79,11 +79,8 @@ void DocumentWriter::appendReplacingData(const String& source)
// FIXME: This should call DocumentParser::appendBytes instead of append
// to support RawDataDocumentParsers.
- if (DocumentParser* parser = m_document->parser()) {
- // Because the parser is pinned to the main thread we don't need to worry about
- // passing ownership of the source string.
- parser->append(source.impl());
- }
+ if (DocumentParser* parser = m_document->parser())
+ parser->append(source);
}
void DocumentWriter::addData(const char* bytes, size_t length)
« no previous file with comments | « Source/core/inspector/DOMPatchSupport.cpp ('k') | Source/core/xml/parser/XMLDocumentParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698