Source/core/inspector/DOMPatchSupport.cpp - Issue 799803004: Demistify DocumentParser::append

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/DOMPatchSupport.cpp

Issue 799803004: Demistify DocumentParser::append (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: resurrect fixme Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/inspector/DOMPatchSupport.cpp

diff --git a/Source/core/inspector/DOMPatchSupport.cpp b/Source/core/inspector/DOMPatchSupport.cpp

index 60e49c7d5a897ef47d8607d1a42a0209fc00f8c5..fb261f4eb0445fb2e67e90c9580f984a2fc0254e 100644

--- a/Source/core/inspector/DOMPatchSupport.cpp

+++ b/Source/core/inspector/DOMPatchSupport.cpp

@@ -96,7 +96,7 @@ void DOMPatchSupport::patchDocument(const String& markup)

newDocument->setContextFeatures(document().contextFeatures());

if (!document().isHTMLDocument()) {

RefPtrWillBeRawPtr<DocumentParser> parser = XMLDocumentParser::create(*newDocument, nullptr);

- parser->append(markup.impl());

+ parser->append(markup);

parser->finish();

parser->detach();