Source/core/xml/parser/XMLDocumentParser.h - Issue 799803004: Demistify DocumentParser::append

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/parser/XMLDocumentParser.h

Issue 799803004: Demistify DocumentParser::append (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: resurrect fixme Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/xml/parser/XMLDocumentParser.h

diff --git a/Source/core/xml/parser/XMLDocumentParser.h b/Source/core/xml/parser/XMLDocumentParser.h

index 75b30e78ead7fe8084b298b92d3c8d140f6e24f1..9d502b29f77b31737574bf1f71a068ceb8d70f35 100644

--- a/Source/core/xml/parser/XMLDocumentParser.h

+++ b/Source/core/xml/parser/XMLDocumentParser.h

@@ -108,7 +108,7 @@ private:

// From DocumentParser

virtual void insert(const SegmentedString&) override;

- virtual void append(PassRefPtr<StringImpl>) override;

+ virtual void append(const String&) override;

virtual void finish() override;

virtual bool isWaitingForScripts() const override;

virtual void stopParsing() override;

« no previous file with comments | « Source/core/loader/DocumentWriter.cpp ('k') | Source/core/xml/parser/XMLDocumentParser.cpp » ('j') | no next file with comments »