remove some dead visual studio < 2013 code

remove some dead visual studio < 2013 code

We only support building for windows with Visual Studio 2013 Update 4
now, so let's remove dead code that is only used for older Visual
Studio versions.

BUG=442035, 158570
Committed: https://crrev.com/7e42a8f70f08bb903ba610afd573ebbfdce5a1d6
Cr-Commit-Position: refs/heads/master@{#309187}

[Mostyn Bramley-Moore, 2014-12-13 08:13:44]

mostynb@opera.com changed reviewers:
+ cpu@chromium.org, dalecurtis@chromium.org, hclam@chromium.org,
thakis@chromium.org

[Mostyn Bramley-Moore, 2014-12-13 08:15:01]

mostynb@opera.com changed reviewers:
+ keybuk@chromium.org

[Mostyn Bramley-Moore, 2014-12-13 08:15:42]

@Nico: PTAL at base/
@cpu: PTAL at chrome/app/ and components/crash/
@DaleCurtis: PTAL at content/browser/media/ and media/cdm/ppapi/
@keybuk: PTAL at device/bluetooth/
@Alpha: PTAL at jingle/notifier/base/

[Mostyn Bramley-Moore, 2014-12-13 11:39:23]

mostynb@opera.com changed reviewers:
+ dgrogan@chromium.org, scottmg@chromium.org

[Mostyn Bramley-Moore, 2014-12-13 11:42:08]

@dgrogan (and scottmg): PTAL at third_party/leveldatabase/port/port_chromium.h

Note: I'm skipping these changes in third party code, unless the _MSC_VER check
is a chromium patch (as this file seems to be).

[scottmg, 2014-12-13 20:11:02]

lgtm

https://codereview.chromium.org/798163004/diff/60001/content/browser/media/me...
File content/browser/media/media_browsertest.cc (left):

https://codereview.chromium.org/798163004/diff/60001/content/browser/media/me...
content/browser/media/media_browsertest.cc:20: #define MAYBE(x) x
remove this and the MAYBEs below too

https://codereview.chromium.org/798163004/diff/60001/jingle/notifier/base/xmp...
File jingle/notifier/base/xmpp_connection_unittest.cc (right):

https://codereview.chromium.org/798163004/diff/60001/jingle/notifier/base/xmp...
jingle/notifier/base/xmpp_connection_unittest.cc:106: #if !defined(_MSC_VER) //
http://crbug.com/158570
These are just buggy. :( I guess add 158570 to the BUG= line.

[Mostyn Bramley-Moore, 2014-12-13 20:22:45]

https://codereview.chromium.org/798163004/diff/60001/content/browser/media/me...
File content/browser/media/media_browsertest.cc (left):

https://codereview.chromium.org/798163004/diff/60001/content/browser/media/me...
content/browser/media/media_browsertest.cc:20: #define MAYBE(x) x
On 2014/12/13 20:11:02, scottmg wrote:
> remove this and the MAYBEs below too

Done.  I should have spotted that myself :)

https://codereview.chromium.org/798163004/diff/60001/jingle/notifier/base/xmp...
File jingle/notifier/base/xmpp_connection_unittest.cc (right):

https://codereview.chromium.org/798163004/diff/60001/jingle/notifier/base/xmp...
jingle/notifier/base/xmpp_connection_unittest.cc:106: #if !defined(_MSC_VER) //
http://crbug.com/158570
On 2014/12/13 20:11:02, scottmg wrote:
> These are just buggy. :( I guess add 158570 to the BUG= line.

Done.

[dgrogan, 2014-12-14 00:53:01]

third_party/leveldatabase lgtm

I have no opinion on whether this is something we actually want to do though.

[Nico, 2014-12-14 01:36:20]

lgtm!

[DaleCurtis, 2014-12-15 18:50:56]

lgtm

[cpu_(ooo_6.6-7.5), 2014-12-15 23:15:06]

lgtm

[keybuk, 2014-12-15 23:19:16]

keybuk@chromium.org changed reviewers:
+ rpaquay@chromium.org
- keybuk@chromium.org

[rpaquay, 2014-12-16 20:42:28]

lgtm

[Mostyn Bramley-Moore, 2014-12-19 11:29:57]

mostynb@opera.com changed reviewers:
+ zea@chromium.org

[Mostyn Bramley-Moore, 2014-12-19 11:30:18]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-12-19 11:30:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/798163004/80001

[commit-bot: I haz the power, 2014-12-19 12:48:15]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-12-19 12:49:09]

Patchset 5 (id:??) landed as
https://crrev.com/7e42a8f70f08bb903ba610afd573ebbfdce5a1d6
Cr-Commit-Position: refs/heads/master@{#309187}