remove some dead visual studio < 2013 code

jingle/notifier/base/xmpp_connection_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "jingle/notifier/base/xmpp_connection.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 85 matching lines @@
   scoped_ptr<MockPreXmppAuth> mock_pre_xmpp_auth_;
   scoped_refptr<net::TestURLRequestContextGetter> url_request_context_getter_;
 };
 
 TEST_F(XmppConnectionTest, CreateDestroy) {
   XmppConnection xmpp_connection(buzz::XmppClientSettings(),
                                  url_request_context_getter_,
                                  &mock_xmpp_connection_delegate_, NULL);
 }
 
-#if !defined(_MSC_VER) || _MSC_VER < 1700 // http://crbug.com/158570
+#if !defined(_MSC_VER) // http://crbug.com/158570

[scottmg, 2014/12/13 20:11:02]

These are just buggy. :( I guess add 158570 to the BUG= line.

[Mostyn Bramley-Moore, 2014/12/13 20:22:45]

Done.

 TEST_F(XmppConnectionTest, ImmediateFailure) {
   // ChromeAsyncSocket::Connect() will always return false since we're
   // not setting a valid host, but this gets bubbled up as ERROR_NONE
   // due to XmppClient's inconsistent error-handling.
   EXPECT_CALL(mock_xmpp_connection_delegate_,
               OnError(buzz::XmppEngine::ERROR_NONE, 0, NULL));
 
   XmppConnection xmpp_connection(buzz::XmppClientSettings(),
                                  url_request_context_getter_,
                                  &mock_xmpp_connection_delegate_, NULL);
@@ skipping 86 matching lines @@
         SignalStateChange(buzz::XmppEngine::STATE_OPEN);
     for (int i = 0; i < 3; ++i) {
       xmpp_connection.weak_xmpp_client_->
           SignalStateChange(buzz::XmppEngine::STATE_OPEN);
     }
 
     EXPECT_EQ(xmpp_connection.weak_xmpp_client_.get(), weak_ptr.get());
   }, "more than once");
 }
 
-#if !defined(_MSC_VER) || _MSC_VER < 1700 // http://crbug.com/158570
+#if !defined(_MSC_VER) // http://crbug.com/158570
 TEST_F(XmppConnectionTest, ConnectThenError) {
   base::WeakPtr<rtc::Task> weak_ptr;
   EXPECT_CALL(mock_xmpp_connection_delegate_, OnConnect(_)).
       WillOnce(SaveArg<0>(&weak_ptr));
   EXPECT_CALL(mock_xmpp_connection_delegate_,
               OnError(buzz::XmppEngine::ERROR_NONE, 0, NULL));
 
   XmppConnection xmpp_connection(buzz::XmppClientSettings(),
                                  url_request_context_getter_,
                                  &mock_xmpp_connection_delegate_, NULL);
@@ skipping 25 matching lines @@
         .WillByDefault(Return(TASK_STATE_ERROR));
     EXPECT_CALL(*task, ProcessStart()).Times(0);
     task->Start();
   }
 
   // This should destroy |task_pump|, but |task| still shouldn't run.
   message_loop_->RunUntilIdle();
 }
 
 }  // namespace notifier