Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: chrome/app/delay_load_hook_win.cc

Issue 798163004: remove some dead visual studio < 2013 code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove MAYBE macro completely Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/delay_load_hook_win.h" 5 #include "chrome/app/delay_load_hook_win.h"
6 6
7 #if defined(_WIN32_WINNT_WIN8) && _MSC_VER < 1700
8 // The Windows 8 SDK defines FACILITY_VISUALCPP in winerror.h, and in
9 // delayimp.h previous to VS2012.
10 #undef FACILITY_VISUALCPP
11 #endif
12 #include <DelayIMP.h> 7 #include <DelayIMP.h>
13 8
14 #include "base/logging.h" 9 #include "base/logging.h"
15 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
16 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
17 12
18 // So long as these symbols are supplied to the final binary through an 13 // So long as these symbols are supplied to the final binary through an
19 // object file (as opposed to indirectly through a library), these pointers 14 // object file (as opposed to indirectly through a library), these pointers
20 // will override the CRT's symbols and direct the notifications to our hook. 15 // will override the CRT's symbols and direct the notifications to our hook.
21 // Alternatively referencing the ChromeDelayLoadHook function somehow will 16 // Alternatively referencing the ChromeDelayLoadHook function somehow will
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 71
77 default: 72 default:
78 NOTREACHED() << "Impossible delay load notification."; 73 NOTREACHED() << "Impossible delay load notification.";
79 break; 74 break;
80 } 75 }
81 76
82 // Returning NULL causes the delay load machinery to perform default 77 // Returning NULL causes the delay load machinery to perform default
83 // processing for this notification. 78 // processing for this notification.
84 return NULL; 79 return NULL;
85 } 80 }
OLDNEW
« no previous file with comments | « chrome/app/delay_load_hook_unittest_win.cc ('k') | components/crash/app/hard_error_handler_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698