Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 79603002: ResourceProvider should be able to avoid allocating immutable textures. (Closed)

Created:
7 years, 1 month ago by rosca
Modified:
7 years ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, webkitbugtracker_adobe.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

ResourceProvider should be able to avoid allocating immutable textures. copyTexImage2D will fail when called on a texture having immutable storage, allocated using texStorage2DEXT. I encountered this problem while working on mix-blend-mode in cc: http://crrev.com/23455060#msg51. This problem is valid for background filters as well. Background filters unittests pass because the test framework uses mesa, which does not support texture storage. I couldn't create cc_unittests for the same reason. Texture storage currently is supported on windows using angle by default. BUG=243223 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236482

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -4 lines) Patch
M cc/output/gl_renderer.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/resource_provider_unittest.cc View 2 chunks +83 lines, -0 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rosca
Please review.
7 years, 1 month ago (2013-11-20 21:37:12 UTC) #1
danakj
Thank you for the test and explanation, and breaking this out. LTM https://codereview.chromium.org/79603002/diff/1/cc/output/gl_renderer.cc File cc/output/gl_renderer.cc ...
7 years, 1 month ago (2013-11-21 00:20:40 UTC) #2
danakj
Er, LGTM I mean!
7 years, 1 month ago (2013-11-21 00:20:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rosca@adobe.com/79603002/70001
7 years ago (2013-11-21 06:41:38 UTC) #4
commit-bot: I haz the power
7 years ago (2013-11-21 09:55:50 UTC) #5
Message was sent while issue was closed.
Change committed as 236482

Powered by Google App Engine
This is Rietveld 408576698