cc/resources/resource_provider.cc - Issue 79603002: ResourceProvider should be able to avoid allocating immutable textures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/resource_provider.cc

Issue 79603002: ResourceProvider should be able to avoid allocating immutable textures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/resource_provider.cc

diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc

index 61ed04a3ef48c822775a59ab4d46cfba96ff438a..1087f23077f56258c6d955168ba243d2a5e5ed1d 100644

--- a/cc/resources/resource_provider.cc

+++ b/cc/resources/resource_provider.cc

@@ -1692,7 +1692,8 @@ void ResourceProvider::LazyAllocate(Resource* resource) {

DCHECK_EQ(resource->target, static_cast<GLenum>(GL_TEXTURE_2D));

ResourceFormat format = resource->format;

GLC(context3d, context3d->bindTexture(GL_TEXTURE_2D, resource->gl_id));

- if (use_texture_storage_ext_ && IsFormatSupportedForStorage(format)) {

+ if (use_texture_storage_ext_ && IsFormatSupportedForStorage(format) &&

+ resource->hint != TextureUsageFramebuffer) {

GLenum storage_format = TextureToStorageFormat(format);

GLC(context3d, context3d->texStorage2DEXT(GL_TEXTURE_2D,

« no previous file with comments | « cc/output/gl_renderer.cc ('k') | cc/resources/resource_provider_unittest.cc » ('j') | no next file with comments »