[Mac Extensions Toolbar] Make the container's animationEndFrame always valid

[Mac Extensions Toolbar] Make the container's animationEndFrame always valid

Previously, [BrowserActionsContainer animationEndFrame] only returned the
frame after animation once animation had occurred. Replace this with an always-
valid animationEndFrame method that returns the frame after animation, or the
current frame if the container is not animating.

Also, move the animation suppression for testing to the ToolbarActionsBar
so that it is platform-independent.

TBR=sky@chromium.org (moving animation suppression flag)
BUG=435518
Committed: https://crrev.com/30ee9094107f43d7335d9d2edff570579f6b41de
Cr-Commit-Position: refs/heads/master@{#308190}

[Devlin, 2014-12-12 07:03:42]

Patchset #1 (id:1) has been deleted

[Devlin, 2014-12-12 07:03:52]

Patchset #1 (id:20001) has been deleted

[Devlin, 2014-12-12 19:17:31]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2014-12-12 19:17:32]

Avi, mind taking a look?

[Avi (use Gerrit), 2014-12-12 19:25:17]

LGTM with naming nit.

https://codereview.chromium.org/795663003/diff/40001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/toolbar_actions_bar.h (right):

https://codereview.chromium.org/795663003/diff/40001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/toolbar_actions_bar.h:135: static bool
disable_animations_during_testing_;
The standard naming convention is "for_testing"; call this
disable_animations_for_testing_.

[Devlin, 2014-12-12 19:39:07]

Patchset #2 (id:60001) has been deleted

[Devlin, 2014-12-12 19:50:13]

Patchset #2 (id:80001) has been deleted

[Devlin, 2014-12-12 19:50:21]

https://codereview.chromium.org/795663003/diff/40001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/toolbar_actions_bar.h (right):

https://codereview.chromium.org/795663003/diff/40001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/toolbar_actions_bar.h:135: static bool
disable_animations_during_testing_;
On 2014/12/12 19:25:17, Avi wrote:
> The standard naming convention is "for_testing"; call this
> disable_animations_for_testing_.

Done.

[Devlin, 2014-12-12 22:07:51]

rdevlin.cronin@chromium.org changed reviewers:
+ sky@chromium.org

[Devlin, 2014-12-12 22:07:55]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-12-12 22:09:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795663003/100001

[commit-bot: I haz the power, 2014-12-12 23:15:02]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2014-12-12 23:15:50]

Patchset 2 (id:??) landed as
https://crrev.com/30ee9094107f43d7335d9d2edff570579f6b41de
Cr-Commit-Position: refs/heads/master@{#308190}