[Mac Extensions Toolbar] Make the container's animationEndFrame always valid

chrome/browser/ui/toolbar/toolbar_actions_bar.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_H_
 #define CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_H_
 
 #include "base/macros.h"
 #include "base/memory/scoped_vector.h"
 #include "base/scoped_observer.h"
@@ skipping 101 matching lines @@
   // overflow and main containers.
   void OnDragDrop(int dragged_index,
                   int dropped_index,
                   DragType drag_type);
 
   const std::vector<ToolbarActionViewController*>& toolbar_actions() {
     return toolbar_actions_.get();
   }
   bool enabled() const { return model_ != nullptr; }
   bool suppress_layout() const { return suppress_layout_; }
-  bool suppress_animation() const { return suppress_animation_; }
+  bool suppress_animation() const {
+    return suppress_animation_ || disable_animations_during_testing_;
+  }
   bool is_highlighting() const { return model_ && model_->is_highlighting(); }
   const PlatformSettings& platform_settings() const {
     return platform_settings_;
   }
 
   ToolbarActionsBarDelegate* delegate_for_test() { return delegate_; }
 
+  // During testing we can disable animations by setting this flag to true,
+  // so that the bar resizes instantly, instead of having to poll it while it
+  // animates to open/closed status.
+  static bool disable_animations_during_testing_;

[Avi (use Gerrit), 2014/12/12 19:25:17]

The standard naming convention is "for_testing"; call this
disable_animations_for_testing_.

[Devlin, 2014/12/12 19:50:21]

Done.

+
  private:
   using ToolbarActions = ScopedVector<ToolbarActionViewController>;
 
   // ExtensionToolbarModel::Observer:
   void ToolbarExtensionAdded(const extensions::Extension* extension,
                              int index) override;
   void ToolbarExtensionRemoved(const extensions::Extension* extension) override;
   void ToolbarExtensionMoved(const extensions::Extension* extension,
                              int index) override;
   void ToolbarExtensionUpdated(const extensions::Extension* extension) override;
@@ skipping 62 matching lines @@
   bool suppress_layout_;
 
   // True if we should suppress animation; we do this when first creating the
   // toolbar, and also when switching tabs changes the state of the icons.
   bool suppress_animation_;
 
   DISALLOW_COPY_AND_ASSIGN(ToolbarActionsBar);
 };
 
 #endif  // CHROME_BROWSER_UI_TOOLBAR_TOOLBAR_ACTIONS_BAR_H_