chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm - Issue 795663003: [Mac Extensions Toolbar] Make the container's animationEndFrame always valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm

Issue 795663003: [Mac Extensions Toolbar] Make the container's animationEndFrame always valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h ('k') | chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm

index c24370c14b264f5150b015bbd61bcedd9020f106..0e844cfdcc6254916226a5e9c3a3ad448c32c1a0 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm

@@ -36,7 +36,6 @@ const CGFloat kMinimumContainerWidth = 10.0;

@implementation BrowserActionsContainerView

-@synthesize animationEndFrame = animationEndFrame_;

@synthesize canDragLeft = canDragLeft_;

@synthesize canDragRight = canDragRight_;

@synthesize grippyPinned = grippyPinned_;

@@ -174,7 +173,6 @@ const CGFloat kMinimumContainerWidth = 10.0;

[[NSAnimationContext currentContext] setDuration:kAnimationDuration];

[[self animator] setFrame:newFrame];

[NSAnimationContext endGrouping];

- animationEndFrame_ = newFrame;

[[NSNotificationCenter defaultCenter]

postNotificationName:kBrowserActionsContainerWillAnimate

@@ -189,6 +187,10 @@ const CGFloat kMinimumContainerWidth = 10.0;

return [self frame].origin.x - lastXPos_;

}

+- (NSRect)animationEndFrame {

+ return [[self animator] frame];

#pragma mark -

#pragma mark Private Methods