Whiltelist the remoting viewer for the Chromoting extension

Whiltelist the remoting viewer for the Chromoting extension

Extensions that ship with plugins may use them. Since the viewer is a
builtin plugin, it doesn't get whitelisted by the usual mechanism.
Explicitly whiltelist it.

BUG=409813
R=bauerb@chromium.org

Committed: https://crrev.com/8731dbe91be06de05856831b8fc6aa7e38cbaf26
Cr-Commit-Position: refs/heads/master@{#308102}

[Bernhard Bauer, 2014-12-12 14:44:37]

https://codereview.chromium.org/794903005/diff/1/chrome/browser/content_setti...
File
chrome/browser/content_settings/content_settings_internal_extension_provider.cc
(right):

https://codereview.chromium.org/794903005/diff/1/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_internal_extension_provider.cc:30:
"gbchcmhmhahfdphkhkmpfmihenigjmpp",  // Chrome Remote Desktop
I never know how whether these initializer lists are indented two spaces or
four. What does clang-format do?

Also, can you add a comment where this list comes from? It should be the set of
extension that are allowed to run the chromoting viewer plugin, right?

https://codereview.chromium.org/794903005/diff/1/chrome/browser/content_setti...
chrome/browser/content_settings/content_settings_internal_extension_provider.cc:51:
// Allow the Chrome Remote Desktop extension to load its internal plugin.
This seems like it could be extracted into a helper method.

[jochen (gone - plz use gerrit), 2014-12-12 14:56:12]

ptal

[jochen (gone - plz use gerrit), 2014-12-12 14:58:47]

also, yes, it's clang-formatted

[Bernhard Bauer, 2014-12-12 15:00:46]

lgtm

https://codereview.chromium.org/794903005/diff/20001/chrome/browser/content_s...
File
chrome/browser/content_settings/content_settings_internal_extension_provider.cc
(right):

https://codereview.chromium.org/794903005/diff/20001/chrome/browser/content_s...
chrome/browser/content_settings/content_settings_internal_extension_provider.cc:182:
if (chrome_remote_desktop_.find(extension->id()) !=
Add a comment that explains the stuff from the CL description? (Remote desktop
uses the plugin bundled with the browser, therefore we explicitly include it
here).

[jochen (gone - plz use gerrit), 2014-12-12 15:07:47]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-12-12 15:08:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/794903005/40001

[commit-bot: I haz the power, 2014-12-12 16:40:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-12 16:41:30]

Patchset 3 (id:??) landed as
https://crrev.com/8731dbe91be06de05856831b8fc6aa7e38cbaf26
Cr-Commit-Position: refs/heads/master@{#308102}