Whiltelist the remoting viewer for the Chromoting extension

chrome/browser/content_settings/content_settings_internal_extension_provider.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/content_settings/content_settings_internal_extension_provider.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_content_client.h"
 #include "chrome/common/extensions/api/plugins/plugins_handler.h"
 #include "components/content_settings/core/browser/content_settings_rule.h"
 #include "components/content_settings/core/common/content_settings.h"
 #include "components/content_settings/core/common/content_settings_pattern.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/notification_types.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/features/simple_feature.h"
 
 using extensions::UnloadedExtensionInfo;
 
 namespace content_settings {
 
+namespace {
+
+const char* kRemotingViewerWhitelist[] = {
+    "gbchcmhmhahfdphkhkmpfmihenigjmpp",  // Chrome Remote Desktop

[Bernhard Bauer, 2014/12/12 14:44:37]

I never know how whether these initializer lists are indented two spaces or
four. What does clang-format do?

Also, can you add a comment where this list comes from? It should be the set of
extension that are allowed to run the chromoting viewer plugin, right?

+    "kgngmbheleoaphbjbaiobfdepmghbfah",  // Pre-release Chrome Remote
+                                         // Desktop
+    "odkaodonbgfohohmklejpjiejmcipmib",  // Dogfood Chrome Remote Desktop
+    "ojoimpklfciegopdfgeenehpalipignm",  // Chromoting canary
+};
+
+}  // namespace
+
+
 InternalExtensionProvider::InternalExtensionProvider(Profile* profile)
     : registrar_(new content::NotificationRegistrar) {
+  for (size_t i = 0; i < arraysize(kRemotingViewerWhitelist); ++i)
+    chrome_remote_desktop_.insert(kRemotingViewerWhitelist[i]);
+
   // Whitelist all extensions loaded so far.
   for (const scoped_refptr<const extensions::Extension>& extension :
        extensions::ExtensionRegistry::Get(profile)->enabled_extensions()) {
     if (extensions::PluginInfo::HasPlugins(extension.get()))
       SetContentSettingForExtension(extension.get(), CONTENT_SETTING_ALLOW);
+
+    // Allow the Chrome Remote Desktop extension to load its internal plugin.

[Bernhard Bauer, 2014/12/12 14:44:37]

This seems like it could be extracted into a helper method.

+    if (chrome_remote_desktop_.find(extension.get()->id()) !=
+        chrome_remote_desktop_.end()) {
+      SetContentSettingForExtensionAndResource(
+          extension.get(), ChromeContentClient::kRemotingViewerPluginPath,
+          CONTENT_SETTING_ALLOW);
+    }
   }
   registrar_->Add(this,
                   extensions::NOTIFICATION_EXTENSION_HOST_CREATED,
                   content::Source<Profile>(profile));
   registrar_->Add(this,
                   extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,
                   content::Source<Profile>(profile));
   registrar_->Add(this,
                   extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,
                   content::Source<Profile>(profile));
@@ skipping 86 matching lines @@
         }
       }
 
       break;
     }
     case extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED: {
       const extensions::Extension* extension =
           content::Details<extensions::Extension>(details).ptr();
       if (extensions::PluginInfo::HasPlugins(extension))
         SetContentSettingForExtension(extension, CONTENT_SETTING_ALLOW);
+
+      // Allow the Chrome Remote Desktop extension to load its internal plugin.
+      if (chrome_remote_desktop_.find(extension->id()) !=
+          chrome_remote_desktop_.end()) {
+        SetContentSettingForExtensionAndResource(
+            extension, ChromeContentClient::kRemotingViewerPluginPath,
+            CONTENT_SETTING_ALLOW);
+      }
       break;
     }
     case extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED: {
       const UnloadedExtensionInfo& info =
           *(content::Details<UnloadedExtensionInfo>(details).ptr());
       if (extensions::PluginInfo::HasPlugins(info.extension))
         SetContentSettingForExtension(info.extension, CONTENT_SETTING_DEFAULT);
+
+      if (chrome_remote_desktop_.find(info.extension->id()) !=
+          chrome_remote_desktop_.end()) {
+        SetContentSettingForExtensionAndResource(
+            info.extension, ChromeContentClient::kRemotingViewerPluginPath,
+            CONTENT_SETTING_DEFAULT);
+      }
       break;
     }
     default:
       NOTREACHED();
   }
 }
 
 void InternalExtensionProvider::ShutdownOnUIThread() {
   DCHECK(CalledOnValidThread());
   RemoveAllObservers();
@@ skipping 34 matching lines @@
                           new base::FundamentalValue(setting));
     }
   }
   NotifyObservers(primary_pattern,
                   secondary_pattern,
                   CONTENT_SETTINGS_TYPE_PLUGINS,
                   resource);
 }
 
 }  // namespace content_settings