Whiltelist the remoting viewer for the Chromoting extension

chrome/browser/content_settings/content_settings_internal_extension_provider.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/content_settings/content_settings_internal_extension_provider.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_content_client.h"
 #include "chrome/common/extensions/api/plugins/plugins_handler.h"
 #include "components/content_settings/core/browser/content_settings_rule.h"
 #include "components/content_settings/core/common/content_settings.h"
 #include "components/content_settings/core/common/content_settings_pattern.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/notification_types.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/features/simple_feature.h"
 
 using extensions::UnloadedExtensionInfo;
 
 namespace content_settings {
 
+namespace {
+
+// This is the set of extensions that are allowed to access the internal
+// remoting viewer plugin.
+const char* kRemotingViewerWhitelist[] = {
+    "gbchcmhmhahfdphkhkmpfmihenigjmpp",  // Chrome Remote Desktop
+    "kgngmbheleoaphbjbaiobfdepmghbfah",  // Pre-release Chrome Remote Desktop
+    "odkaodonbgfohohmklejpjiejmcipmib",  // Dogfood Chrome Remote Desktop
+    "ojoimpklfciegopdfgeenehpalipignm",  // Chromoting canary
+};
+
+}  // namespace
+
+
 InternalExtensionProvider::InternalExtensionProvider(Profile* profile)
     : registrar_(new content::NotificationRegistrar) {
+  for (size_t i = 0; i < arraysize(kRemotingViewerWhitelist); ++i)
+    chrome_remote_desktop_.insert(kRemotingViewerWhitelist[i]);
+
   // Whitelist all extensions loaded so far.
   for (const scoped_refptr<const extensions::Extension>& extension :
        extensions::ExtensionRegistry::Get(profile)->enabled_extensions()) {
-    if (extensions::PluginInfo::HasPlugins(extension.get()))
-      SetContentSettingForExtension(extension.get(), CONTENT_SETTING_ALLOW);
+    ApplyPluginContentSettingsForExtension(extension.get(),
+                                           CONTENT_SETTING_ALLOW);
   }
   registrar_->Add(this,
                   extensions::NOTIFICATION_EXTENSION_HOST_CREATED,
                   content::Source<Profile>(profile));
   registrar_->Add(this,
                   extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,
                   content::Source<Profile>(profile));
   registrar_->Add(this,
                   extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,
                   content::Source<Profile>(profile));
@@ skipping 84 matching lines @@
               ChromeContentClient::kRemotingViewerPluginPath,
               CONTENT_SETTING_ALLOW);
         }
       }
 
       break;
     }
     case extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED: {
       const extensions::Extension* extension =
           content::Details<extensions::Extension>(details).ptr();
-      if (extensions::PluginInfo::HasPlugins(extension))
-        SetContentSettingForExtension(extension, CONTENT_SETTING_ALLOW);
+      ApplyPluginContentSettingsForExtension(extension, CONTENT_SETTING_ALLOW);
       break;
     }
     case extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED: {
       const UnloadedExtensionInfo& info =
           *(content::Details<UnloadedExtensionInfo>(details).ptr());
-      if (extensions::PluginInfo::HasPlugins(info.extension))
-        SetContentSettingForExtension(info.extension, CONTENT_SETTING_DEFAULT);
+      ApplyPluginContentSettingsForExtension(info.extension,
+                                             CONTENT_SETTING_DEFAULT);
       break;
     }
     default:
       NOTREACHED();
   }
 }
 
 void InternalExtensionProvider::ShutdownOnUIThread() {
   DCHECK(CalledOnValidThread());
   RemoveAllObservers();
   registrar_.reset();
 }
 
+void InternalExtensionProvider::ApplyPluginContentSettingsForExtension(
+    const extensions::Extension* extension,
+    ContentSetting setting) {
+  if (extensions::PluginInfo::HasPlugins(extension))
+    SetContentSettingForExtension(extension, setting);
+
+  if (chrome_remote_desktop_.find(extension->id()) !=

[Bernhard Bauer, 2014/12/12 15:00:46]

Add a comment that explains the stuff from the CL description? (Remote desktop
uses the plugin bundled with the browser, therefore we explicitly include it
here).

+      chrome_remote_desktop_.end()) {
+    SetContentSettingForExtensionAndResource(
+        extension, ChromeContentClient::kRemotingViewerPluginPath, setting);
+  }
+}
+
 void InternalExtensionProvider::SetContentSettingForExtension(
     const extensions::Extension* extension,
     ContentSetting setting) {
   SetContentSettingForExtensionAndResource(
       extension, ResourceIdentifier(), setting);
 }
 
 void InternalExtensionProvider::SetContentSettingForExtensionAndResource(
     const extensions::Extension* extension,
     const ResourceIdentifier& resource,
@@ skipping 21 matching lines @@
                           new base::FundamentalValue(setting));
     }
   }
   NotifyObservers(primary_pattern,
                   secondary_pattern,
                   CONTENT_SETTINGS_TYPE_PLUGINS,
                   resource);
 }
 
 }  // namespace content_settings