Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 794603003: [Ozone] Fix build (Closed)

Created:
6 years ago by dnicoara
Modified:
6 years ago
CC:
chromium-reviews, ozone-reviews_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Ozone] Fix build Change Ozone interface to use SkSurface rather than SkCanvas BUG=none TBR=danakj@chromium.org NOTRY=true Committed: https://crrev.com/0783f6673359adb3f8fcbc2f4b1e3ce8621f83fc Cr-Commit-Position: refs/heads/master@{#307703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M content/browser/compositor/software_output_device_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/caca/caca_window_manager.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/test/test_window_manager.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/ozone/public/surface_ozone_canvas.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dnicoara
PTAL Followup to https://codereview.chromium.org/791753002 which broke the Ozone build.
6 years ago (2014-12-10 15:38:56 UTC) #2
alexst (slow to review)
lgtm
6 years ago (2014-12-10 15:40:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794603003/1
6 years ago (2014-12-10 15:42:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-10 15:43:11 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0783f6673359adb3f8fcbc2f4b1e3ce8621f83fc Cr-Commit-Position: refs/heads/master@{#307703}
6 years ago (2014-12-10 15:43:55 UTC) #7
danakj
6 years ago (2014-12-10 16:53:27 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698