SkCanvas::NewRaster is deprecated, create a surface instead

SkCanvas::NewRaster is deprecated, create a surface instead

BUG=skia:3216
Committed: https://crrev.com/62272ad0487d0741c712ceb6674afaf72dc61bb7
Cr-Commit-Position: refs/heads/master@{#307697}

[reed1, 2014-12-09 21:32:26]

reed@google.com changed reviewers:
+ enne@chromium.org, nduca@chromium.org

[reed1, 2014-12-09 21:32:27]

refactoring, need OWNER for cc/

[bungeman-skia, 2014-12-09 21:39:53]

bungeman@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2014-12-09 21:39:54]

https://codereview.chromium.org/791753002/diff/1/cc/output/software_output_de...
File cc/output/software_output_device.cc (right):

https://codereview.chromium.org/791753002/diff/1/cc/output/software_output_de...
cc/output/software_output_device.cc:9: #include
"third_party/skia/include/core/SkCanvas.h"
Looks like SkCanvas can be left forward declared and this just be changed to
SkSurface.h?

https://codereview.chromium.org/791753002/diff/1/cc/output/software_output_de...
File cc/output/software_output_device.h (right):

https://codereview.chromium.org/791753002/diff/1/cc/output/software_output_de...
cc/output/software_output_device.h:12: #include
"third_party/skia/include/core/SkSurface.h"
It looks like SkCanvas was previously just forward declared, should this be as
well?

[enne (OOO), 2014-12-09 21:40:24]

lgtm

Is there a Skia bug that this can be linked to?

[reed1, 2014-12-09 21:48:33]

bug added

https://codereview.chromium.org/791753002/diff/1/cc/output/software_output_de...
File cc/output/software_output_device.h (right):

https://codereview.chromium.org/791753002/diff/1/cc/output/software_output_de...
cc/output/software_output_device.h:12: #include
"third_party/skia/include/core/SkSurface.h"
On 2014/12/09 21:39:54, bungeman1 wrote:
> It looks like SkCanvas was previously just forward declared, should this be as
> well?

The actual type is needed for the RefPtr<>

[reed1, 2014-12-09 21:48:38]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-12-09 21:49:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/791753002/1

[reed1, 2014-12-09 21:54:17]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-12-09 22:40:09]

reed@google.com changed reviewers:
+ jbauman@chromium.org

[reed1, 2014-12-09 22:40:10]

need content/ owner

[jbauman, 2014-12-09 23:15:51]

content/ lgtm

[reed1, 2014-12-10 13:54:00]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-12-10 13:54:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/791753002/40001

[commit-bot: I haz the power, 2014-12-10 14:49:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-10 14:50:21]

Patchset 3 (id:??) landed as
https://crrev.com/62272ad0487d0741c712ceb6674afaf72dc61bb7
Cr-Commit-Position: refs/heads/master@{#307697}

[gunsch, 2014-12-10 16:44:38]

On 2014/12/10 14:50:21, I haz the power (commit-bot) wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/62272ad0487d0741c712ceb6674afaf72dc61bb7
> Cr-Commit-Position: refs/heads/master@{#307697}

FYI: this broke the chromecast/ build (no trybot yet), and I think potentially
any build using Ozone:

FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/content/browser/compositor/content_browser.software_output_device_ozone.o.d
-DCONTENT_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64
-DDISABLE_NACL -DCHROMIUM_BUILD -DCR_CLANG_REVISION=218707
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_OZONE=1
-DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN
-DENABLE_PRE_SYNC_BACKUP -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS
-DENABLE_MPEG2TS_STREAM_PARSER -DENABLE_BROWSER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DDONT_EMBED_BUILD_METADATA
-DLOG_DISABLED=0 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1
-DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DENABLE_LOAD_COMPLETION_HACKS=1 -DENABLE_SCREEN_CAPTURE=1
-DMOJO_USE_SYSTEM_IMPL -DLIBPEERCONNECTION_LIB=1 -DSK_ENABLE_INST_COUNT=0
-DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_IGNORE_GPU_LAYER_HOISTING
-DSK_USE_POSIX_THREADS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0
-DU_STATIC_IMPLEMENTATION -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DCHROME_PNG_WRITE_SUPPORT
-DPNG_USER_CONFIG -DUSE_SYSTEM_LIBJPEG -DFEATURE_ENABLE_SSL
-DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH
-DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DWEBRTC_LINUX -DPOSIX
-DWEBRTC_POSIX -DWEBRTC_CHROMIUM_BUILD -DFLAC__NO_DLL -DUSE_NSS=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -D_GLIBCXX_DEBUG=1 -Igen -I../..
-Iobj/content/content_browser.gen -I../../third_party/khronos -I../../gpu
-I../../skia/config -I../../third_party/WebKit/Source -Igen/angle
-I../../net/third_party/nss/ssl -I../../third_party/skia/src/core
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/re2
-I../../third_party/zlib -I../../third_party/WebKit
-I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
-Igen/ui/resources -Igen/protoc_out -I../../third_party/protobuf
-I../../third_party/protobuf/src -Igen/content/app/resources/ -Igen/webkit
-I../../third_party/leveldatabase/src/include
-I../../third_party/leveldatabase/src -I../../third_party/leveldatabase
-I../../third_party/WebKit -I../../third_party/npapi
-I../../third_party/npapi/bindings -I../../v8/include -I../../third_party/libpng
-I../../third_party/libwebp -I../../third_party/ots/include
-I../../third_party/qcms/src -I../../third_party/iccjpeg
-Igen/content/browser/tracing -I../../third_party/libyuv/include
-I../../third_party/libyuv -I../../third_party/webrtc/overrides
-I../../third_party/libjingle/overrides -I../../third_party/libjingle/source
-I../../testing/gtest/include -I../../third_party
-I../../third_party/fontconfig/src -I../../third_party/speex/include
-fstack-protector --param=ssp-buffer-size=4 -Werror -pthread
-fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers
-fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load
-Xclang
/usr/local/google/home/mosaic-role/slave/repo_clients/chromium_tot/chromium/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
-B/usr/local/google/home/mosaic-role/slave/repo_clients/chromium_tot/chromium/src/third_party/binutils/Linux_x64/Release/bin
-Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wexit-time-destructors -I/usr/include/nss
-I/usr/include/nspr -Wno-header-guard -m64 -march=x86-64 -O0 -g -gdwarf-4
-funwind-tables -gsplit-dwarf -Wno-undefined-bool-conversion
-Wno-tautological-undefined-compare -fno-exceptions -fno-rtti
-fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 
-c ../../content/browser/compositor/software_output_device_ozone.cc -o
obj/content/browser/compositor/content_browser.software_output_device_ozone.o
../../content/browser/compositor/software_output_device_ozone.cc:46:3: error:
use of undeclared identifier 'canvas_'
  canvas_ = surface_ozone_->GetCanvas();
  ^
1 error generated.

[tfarina, 2014-12-10 16:48:52]

On Wed, Dec 10, 2014 at 2:44 PM, <gunsch@chromium.org> wrote:

> On 2014/12/10 14:50:21, I haz the power (commit-bot) wrote:
>
>> Patchset 3 (id:??) landed as
>> https://crrev.com/62272ad0487d0741c712ceb6674afaf72dc61bb7
>> Cr-Commit-Position: refs/heads/master@{#307697}
>>
>
> FYI: this broke the chromecast/ build (no trybot yet), and I think
> potentially
> any build using Ozone:
>
> Could you file a bug for the trybot issue? If not, let me know and will
file one and follow up on there.

CCing Sadrul and Spang for Ozone build issue.


>
> https://codereview.chromium.org/791753002/
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[alexst (slow to review), 2014-12-10 17:05:02]

On 2014/12/10 16:48:52, tfarina wrote:
> On Wed, Dec 10, 2014 at 2:44 PM, <mailto:gunsch@chromium.org> wrote:
> 
> > On 2014/12/10 14:50:21, I haz the power (commit-bot) wrote:
> >
> >> Patchset 3 (id:??) landed as
> >> https://crrev.com/62272ad0487d0741c712ceb6674afaf72dc61bb7
> >> Cr-Commit-Position: refs/heads/master@{#307697}
> >>
> >
> > FYI: this broke the chromecast/ build (no trybot yet), and I think
> > potentially
> > any build using Ozone:
> >
> > Could you file a bug for the trybot issue? If not, let me know and will
> file one and follow up on there.
> 
> CCing Sadrul and Spang for Ozone build issue.
> 
> 
> >
> > https://codereview.chromium.org/791753002/
> >
> 
> 
> 
> -- 
> Thiago Farina
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Danny fixed the build https://codereview.chromium.org/794603003/ and I am
following up on trybots, we need to hook up existing ones to the CQ.