Issue 794343004: Prepare for V8 roll enabling classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 794343004: Prepare for V8 roll enabling classes. (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)

Modified:
6 years ago

Reviewers:
arv (Not doing code reviews), Michael Achenbach

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Prepare for V8 roll enabling classes. TBR=machenbach@chromium.org,arv@chromium.org BUG=chromium:442340 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187153

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/794343004/1

6 years ago (2014-12-15 16:50:27 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=187153

6 years ago (2014-12-15 16:51:11 UTC) #5

arv (Not doing code reviews)

5 years, 11 months ago (2015-01-14 14:02:02 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/786953010/ by arv@chromium.org.

The reason for reverting is: Re-enable tests since we are not shipping classes
yet..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages