Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 786953010: Revert of Prepare for V8 roll enabling classes. (Closed)

Created:
5 years, 11 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Prepare for V8 roll enabling classes. (patchset #1 id:1 of https://codereview.chromium.org/794343004/) Reason for revert: Re-enable tests since we are not shipping classes yet. Original issue's description: > Prepare for V8 roll enabling classes. > > TBR=machenbach@chromium.org,arv@chromium.org > BUG=chromium:442340 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187153 TBR=machenbach@chromium.org,dslomov@chromium.org NOTREECHECKS=true NOTRY=true BUG=chromium:442340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
arv (Not doing code reviews)
Created Revert of Prepare for V8 roll enabling classes.
5 years, 11 months ago (2015-01-14 14:02:02 UTC) #1
arv (Not doing code reviews)
Here you go Phillip.
5 years, 11 months ago (2015-01-14 14:02:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786953010/1
5 years, 11 months ago (2015-01-14 14:03:17 UTC) #4
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 11 months ago (2015-01-14 14:03:31 UTC) #6
philipj_slow
Thanks! LGTM, but you'll need to also update the tests since the expectations haven't been ...
5 years, 11 months ago (2015-01-14 14:52:56 UTC) #7
arv (Not doing code reviews)
On 2015/01/14 14:52:56, philipj wrote: > Thanks! LGTM, but you'll need to also update the ...
5 years, 11 months ago (2015-01-14 15:35:49 UTC) #8
philipj_slow
Done manually in https://codereview.chromium.org/813043004/
5 years, 11 months ago (2015-01-19 10:16:26 UTC) #9
philipj_slow
On 2015/01/19 10:16:26, philipj wrote: > Done manually in https://codereview.chromium.org/813043004/ Erik, if Jochen doesn't get ...
5 years, 11 months ago (2015-01-19 14:28:52 UTC) #10
philipj_slow
5 years, 11 months ago (2015-01-21 15:04:37 UTC) #11
This review can be closed now.

Powered by Google App Engine
This is Rietveld 408576698