Source/bindings/core/v8/ScriptProfiler.cpp - Issue 794223003: Cheaper thread-safe atomic initialization of static references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptProfiler.cpp

Issue 794223003: Cheaper thread-safe atomic initialization of static references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add type check for initial value Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/ScriptProfiler.cpp

diff --git a/Source/bindings/core/v8/ScriptProfiler.cpp b/Source/bindings/core/v8/ScriptProfiler.cpp

index 7db431217e51ba7cc18291a631040d1bee581414..ec70515af708c5475b2d6b490acb45fbd71d4fc7 100644

--- a/Source/bindings/core/v8/ScriptProfiler.cpp

+++ b/Source/bindings/core/v8/ScriptProfiler.cpp

@@ -305,8 +305,8 @@ void ScriptProfiler::visitNodeWrappers(WrappedNodeVisitor* visitor)

ProfileNameIdleTimeMap* ScriptProfiler::currentProfileNameIdleTimeMap()

{

- AtomicallyInitializedStatic(WTF::ThreadSpecific<ProfileNameIdleTimeMap>*, map = new WTF::ThreadSpecific<ProfileNameIdleTimeMap>);

- return *map;

+ AtomicallyInitializedStaticReference(WTF::ThreadSpecific<ProfileNameIdleTimeMap>, map, new WTF::ThreadSpecific<ProfileNameIdleTimeMap>);

+ return map;

}

void ScriptProfiler::setIdle(bool isIdle)

« no previous file with comments | « Source/bindings/core/v8/Dictionary.cpp ('k') | Source/bindings/core/v8/V8Initializer.cpp » ('j') | Source/wtf/Threading.h » ('J')