Source/bindings/core/v8/Dictionary.cpp - Issue 794223003: Cheaper thread-safe atomic initialization of static references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/Dictionary.cpp

Issue 794223003: Cheaper thread-safe atomic initialization of static references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add type check for initial value Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/Dictionary.cpp

diff --git a/Source/bindings/core/v8/Dictionary.cpp b/Source/bindings/core/v8/Dictionary.cpp

index bc3b7cc0a7a007757d41d305d6daf4a7864897ae..91b09a48d1f3e5ddc70a0b17a746f658336fead6 100644

--- a/Source/bindings/core/v8/Dictionary.cpp

+++ b/Source/bindings/core/v8/Dictionary.cpp

@@ -48,8 +48,8 @@ namespace blink {

static ExceptionState& emptyExceptionState()

{

- AtomicallyInitializedStatic(WTF::ThreadSpecific<NonThrowableExceptionState>*, exceptionState = new ThreadSpecific<NonThrowableExceptionState>);

- return **exceptionState;

+ AtomicallyInitializedStaticReference(WTF::ThreadSpecific<NonThrowableExceptionState>, exceptionState, new ThreadSpecific<NonThrowableExceptionState>);

+ return *exceptionState;

}

Dictionary::Dictionary()

« no previous file with comments | « no previous file | Source/bindings/core/v8/ScriptProfiler.cpp » ('j') | Source/wtf/Threading.h » ('J')