Source/bindings/core/v8/V8Initializer.cpp - Issue 794223003: Cheaper thread-safe atomic initialization of static references.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8Initializer.cpp

Issue 794223003: Cheaper thread-safe atomic initialization of static references. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add type check for initial value Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8Initializer.cpp

diff --git a/Source/bindings/core/v8/V8Initializer.cpp b/Source/bindings/core/v8/V8Initializer.cpp

index 967a9f2e0c2a36fcc5ecd08adb021f02b9506db6..939d7928a04d57ddcd9d8bfae897a9eb4205ebe2 100644

--- a/Source/bindings/core/v8/V8Initializer.cpp

+++ b/Source/bindings/core/v8/V8Initializer.cpp

@@ -242,8 +242,8 @@ typedef Deque<PromiseRejectMessage> PromiseRejectMessageQueue;

static PromiseRejectMessageQueue& promiseRejectMessageQueue()

{

- AtomicallyInitializedStatic(ThreadSpecific<PromiseRejectMessageQueue>*, queue = new ThreadSpecific<PromiseRejectMessageQueue>);

- return **queue;

+ AtomicallyInitializedStaticReference(ThreadSpecific<PromiseRejectMessageQueue>, queue, new ThreadSpecific<PromiseRejectMessageQueue>);

+ return *queue;

}

void V8Initializer::reportRejectedPromises()

« no previous file with comments | « Source/bindings/core/v8/ScriptProfiler.cpp ('k') | Source/core/dom/DOMArrayBuffer.h » ('j') | Source/wtf/Threading.h » ('J')