Implement WebPushProvider.unregister() in Chromium.

content/child/push_messaging/push_provider.h

Index: content/child/push_messaging/push_provider.h
diff --git a/content/child/push_messaging/push_provider.h b/content/child/push_messaging/push_provider.h
index 313a304a5cbdb1dd661ab40684b0b715afb1ba2a..1bdbe6d29abf59cf8d427a90edc8e98de0521a1b 100644
--- a/content/child/push_messaging/push_provider.h
+++ b/content/child/push_messaging/push_provider.h
@@ -33,10 +33,12 @@ class PushProvider : public blink::WebPushProvider,
   void OnWorkerRunLoopStopped() override;
 
   // blink::WebPushProvider implementation.
-  void registerPushMessaging(blink::WebServiceWorkerRegistration*,
-                             blink::WebPushRegistrationCallbacks*) override;
-  void getPermissionStatus(blink::WebServiceWorkerRegistration*,
-                           blink::WebPushPermissionStatusCallbacks*) override;
+  virtual void registerPushMessaging(blink::WebServiceWorkerRegistration*,
+                                     blink::WebPushRegistrationCallbacks*);
+  virtual void getPermissionStatus(blink::WebServiceWorkerRegistration*,
+                                   blink::WebPushPermissionStatusCallbacks*);
+  virtual void unregister(blink::WebServiceWorkerRegistration*,

[johnme, 2014/12/15 12:07:16]

Ditto method order. And below.

+                          blink::WebPushUnregisterCallbacks*);
 
   // Called by the PushDispatcher.
   bool OnMessageReceived(const IPC::Message& message);
@@ -53,6 +55,7 @@ class PushProvider : public blink::WebPushProvider,
   void OnGetPermissionStatusSuccess(int request_id,
                                     blink::WebPushPermissionStatus status);
   void OnGetPermissionStatusError(int request_id);
+  void OnUnregisterResponse(int request_id, bool unregistered);

[Michael van Ouwerkerk, 2014/12/15 12:29:14]

I'd like more clarity on the meaning of this boolean before committing. Is it
"operation success" or "registration state is unregistered"? When unregistering
the same registration twice, the first meaning could be false and the second
true, for the same end result.

[Michael van Ouwerkerk, 2014/12/16 11:36:51]

From [1] it seems your intent is to signal whether the operation succeeded, not
whether the current state is unregistered. Please rename |unregistered| to
|success|.

[1] https://github.com/w3c/push-api/pull/97#issuecomment-67039200

 
   scoped_refptr<ThreadSafeSender> thread_safe_sender_;
   scoped_refptr<PushDispatcher> push_dispatcher_;
@@ -66,6 +69,10 @@ class PushProvider : public blink::WebPushProvider,
   std::map<int, blink::WebPushPermissionStatusCallbacks*>
       permission_status_callbacks_;
 
+  // Stores the unregistration callbacks with their request ids. This class owns
+  // the callbacks.
+  std::map<int, blink::WebPushUnregisterCallbacks*> unregister_callbacks_;
+
   DISALLOW_COPY_AND_ASSIGN(PushProvider);
 };